- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
Stabilize Ident::new_raw #75084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            Stabilize Ident::new_raw #75084
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
          
 (rust_highfive has picked a reviewer for you, use r? to override)  | 
    
              
                    petrochenkov
  
              
              reviewed
              
                  
                    Aug 3, 2020 
                  
              
              
            
            
| 
           FCP already happened in #59002, so this PR shouldn't need a new one.  | 
    
bdba12c    to
    f9d2f54      
    Compare
  
    | 
           @petrochenkov: I've addressed your comments  | 
    
              
                    petrochenkov
  
              
              reviewed
              
                  
                    Aug 3, 2020 
                  
              
              
            
            
| 
           r=me with the extra word removed and commits squashed  | 
    
Tracking issue: rust-lang#54723 This is a continuation of PR rust-lang#59002
f9d2f54    to
    6deda6a      
    Compare
  
    | 
           @petrochenkov: Squashed  | 
    
| 
           @bors r+  | 
    
| 
           📌 Commit 6deda6a has been approved by   | 
    
    
  JohnTitor 
      added a commit
        to JohnTitor/rust
      that referenced
      this pull request
    
      Aug 3, 2020 
    
    
      
  
    
      
    
  
…r=petrochenkov Stabilize Ident::new_raw Tracking issue: rust-lang#54723 This is a continuation of PR rust-lang#59002
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      Aug 4, 2020 
    
    
      
  
    
      
    
  
Rollup of 8 pull requests Successful merges: - rust-lang#74759 (add `unsigned_abs` to signed integers) - rust-lang#75043 (rustc_ast: `(Nested)MetaItem::check_name` -> `has_name`) - rust-lang#75056 (Lint path statements to suggest using drop when the type needs drop) - rust-lang#75081 (Fix logging for rustdoc) - rust-lang#75083 (Do not trigger `unused_braces` for `while let`) - rust-lang#75084 (Stabilize Ident::new_raw) - rust-lang#75103 (Disable building rust-analyzer on riscv64) - rust-lang#75106 (Enable docs on in the x86_64-unknown-linux-musl manifest) Failed merges: r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    relnotes
  Marks issues that should be documented in the release notes of the next release. 
  
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  
    T-libs-api
  Relevant to the library API team, which will review and decide on the PR/issue. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Tracking issue: #54723
This is a continuation of PR #59002