Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Layout::array() in raw_vec.rs. #75093

Closed
wants to merge 1 commit into from

Conversation

nnethercote
Copy link
Contributor

A non-generic equivalent results in less LLVM IR and faster compilation.

r? @Amanieu

A non-generic equivalent results in less LLVM IR and faster compilation.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 3, 2020
@nnethercote
Copy link
Contributor Author

This gave me wins of up to 1.9% locally, but changes to this code can be unpredictable in terms of performance, so let's see what it looks like on CI.

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Aug 3, 2020

⌛ Trying commit 894236f with merge f7180d1a199036f6f96d6791cbe6f58b00a890a4...

@bors
Copy link
Contributor

bors commented Aug 3, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: f7180d1a199036f6f96d6791cbe6f58b00a890a4 (f7180d1a199036f6f96d6791cbe6f58b00a890a4)

@rust-timer
Copy link
Collaborator

Queued f7180d1a199036f6f96d6791cbe6f58b00a890a4 with parent 1b0ff9e, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (f7180d1a199036f6f96d6791cbe6f58b00a890a4): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@mati865
Copy link
Contributor

mati865 commented Aug 3, 2020

Small max-rss improvement, minimal regression everywhere else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants