lint/ty: move fns to avoid abstraction violation #75099
Merged
+27
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
eddyb
reviewed
Aug 16, 2020
eddyb
reviewed
Aug 16, 2020
davidtwco
force-pushed
the
is-zst-abstraction-violation
branch
from
50d97c0 to
6e550b9
Compare
eddyb
reviewed
Aug 18, 2020
davidtwco
force-pushed
the
is-zst-abstraction-violation
branch
from
6e550b9 to
474f3d2
Compare
This comment has been minimized.
This comment has been minimized.
davidtwco
force-pushed
the
is-zst-abstraction-violation
branch
from
474f3d2 to
6cc6900
Compare
This comment has been minimized.
This comment has been minimized.
davidtwco
force-pushed
the
is-zst-abstraction-violation
branch
from
6cc6900 to
623851e
Compare
This comment has been minimized.
This comment has been minimized.
This commit moves `transparent_newtype_field` and `is_zst` to `LateContext` where they are used, rather than being on the `VariantDef` and `TyS` types. Signed-off-by: David Wood <david@davidtw.co>
davidtwco
force-pushed
the
is-zst-abstraction-violation
branch
from
623851e to
0f2bd56
Compare
crlf0710
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 0f2bd56 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 19, 2020
…ion, r=eddyb lint/ty: move fns to avoid abstraction violation This PR moves `transparent_newtype_field` and `is_zst` to `LateContext` where they are used, rather than being on the `VariantDef` and `TyS` types, hopefully addressing @eddyb's concern [from this comment](rust-lang#74340 (comment)).
|
@bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2020
Rollup of 14 pull requests Successful merges: - rust-lang#73963 (deny(unsafe_op_in_unsafe_fn) in libstd/path.rs) - rust-lang#75099 (lint/ty: move fns to avoid abstraction violation) - rust-lang#75502 (Use implicit (not explicit) rules for promotability by default in `const fn`) - rust-lang#75580 (Add test for checking duplicated branch or-patterns) - rust-lang#76310 (Add `[T; N]: TryFrom<Vec<T>>` (insta-stable)) - rust-lang#76400 (Clean up vec benches bench_in_place style) - rust-lang#76434 (do not inline black_box when building for Miri) - rust-lang#76492 (Add associated constant `BITS` to all integer types) - rust-lang#76525 (Add as_str() to string::Drain.) - rust-lang#76636 (assert ScalarMaybeUninit size) - rust-lang#76749 (give *even better* suggestion when matching a const range) - rust-lang#76757 (don't convert types to the same type with try_into (clippy::useless_conversion)) - rust-lang#76796 (Give a better error message when x.py uses the wrong stage for CI) - rust-lang#76798 (Build fixes for RISC-V 32-bit Linux support) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
transparent_newtype_fieldandis_zsttoLateContextwhere they are used, rather than being on theVariantDefandTyStypes, hopefully addressing @eddyb's concern from this comment.