-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid recompiling std when tests change in std::net #75108
Conversation
Avoid recompiling std when tests changed
The reason we do it in a new commit is to avoid changing tests when moving it around.
Thanks @lzutao! It looks like we don’t have a really consistent approach to organizing tests here in |
I am modifying things in #75110 . It is kind of painful when I only change tests to investigate fall outs in that PR |
@KodrAus Should I open an MCP on compiler team repo to enforce tests module in separate file? |
☔ The latest upstream changes (presumably #75019) made this pull request unmergeable. Please resolve the merge conflicts. |
I wasn't actually aware that moving |
Reopened the proposal in #75979. |
I moved ui tests to their own files.
It's best when review commit by commit.
I could squash them all if requested.
r? @KodrAus