Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the type of AssertModuleSource::available_cgus. #75210

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Change the type of AssertModuleSource::available_cgus. #75210

merged 1 commit into from
Aug 7, 2020

Commits on Aug 6, 2020

  1. Change the type of AssertModuleSource::available_cgus. 

    It's currently a `BTreeSet<Symbol>`, which is a strange type. The
`BTreeSet` suggests that element order is important, but `Symbol` is a
type whose ordering isn't useful to humans. The ordering of the
collection only manifests in an obscure error message ("no module named
`...`") that doesn't appear in any tests.

This commit changes the `Symbol` to a `String`, which is more
typical.
    @nnethercote
    nnethercote committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    ebbf07a View commit details
    Browse the repository at this point in the history