Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep stdout open in limit_vector_count test #75228

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Keep stdout open in limit_vector_count test #75228

merged 1 commit into from
Aug 6, 2020

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Aug 6, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @kennytm

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 6, 2020
@tmiasko tmiasko mentioned this pull request Aug 6, 2020
Merged
@tmiasko
Copy link
Contributor Author

tmiasko commented Aug 6, 2020

Unintentional close of stdout caused issues on CI in #75121, #75206, #75215, and #74888, so this should be prioritized.

@ecstatic-morse
Copy link
Contributor

@bors r+ p=5

@bors
Copy link
Contributor

bors commented Aug 6, 2020

📌 Commit 888bc07 has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2020
@bors
Copy link
Contributor

bors commented Aug 6, 2020

⌛ Testing commit 888bc07 with merge 71f8d0c...

@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented Aug 6, 2020 •
edited
Loading

cc @adamreichold #75005

Good find by the way.

@adamreichold
Copy link
Contributor

adamreichold commented Aug 6, 2020 •
edited
Loading

cc @adamreichold #75005

Good find by the way.

I am sorry for the issues and annoyance this has caused. With hindsight, a temporary file would probably have a been better choice. :-(

@JohnTitor JohnTitor mentioned this pull request Aug 6, 2020
Merged
@bors
Copy link
Contributor

bors commented Aug 6, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: ecstatic-morse
Pushing 71f8d0c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 6, 2020
@bors bors merged commit 71f8d0c into rust-lang:master Aug 6, 2020
@tmiasko tmiasko deleted the keep-stdout-open branch August 7, 2020 04:56
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kennytm kennytm

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tmiasko @rust-highfive @ecstatic-morse @bors @adamreichold @cuviper @kennytm