Add str::starts_with_at() #7533
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same as starts_with(), but takes an additional `begin` argument, an index in the string where to start looking.
|
For the sake of completeness, could you please add a test for it? |
|
Is this necessary? What about |
|
I don't think we need functions like this since slicing is composable with the existing operations. There are many different types of indexing (byte, code point, grapheme) and you can index both the start and the end, so there's just too much variety to special case each function. |
|
Ok, |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 12, 2021
…r=xFrednet fix bug on mutable ref fixes: rust-lang#7524 This PR is related to issue rust-lang#7524 changelog: [`extend_with_drain`] Improve code suggestion for mutable and immutable references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as starts_with(), but takes an additional
beginargument, an index in the string where to start looking. (Note: this is untested.)