librustc_metadata::locator: Properly detect file type. #75548
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Make sure to test for file types against the non-canonicalized name to avoid detecting the wrong type. Some systems save build artifacts into associative file stores that do not preserve extensions, and then link to those using conventionally-named symbolic links that are the arguments to `rustc` et al. If we canonicalize before testing the type, we resolve the symlink, the extension is lost and we might treat rlibs and rmetas as dylibs. The fix is to introduce a temporary to hold the canonicalized name, compare against the non-canonical name, and add a comment explaining what's going on for the would-be maintainer who sees a potential cleanup. Signed-off-by: Dan Cross <dcross@google.com>
|
Looks reasonable to me, but consider adding a test (probably run-make) in a follow-up if you want to prevent this from breaking in the future. @bors r+ |
|
📌 Commit 6ad6d8c has been approved by |
bors
added
S-waiting-on-bors
Rollup of 3 pull requests Successful merges: - rust-lang#75548 (librustc_metadata::locator: Properly detect file type.) - rust-lang#75603 (Use more compatible out-implib style) - rust-lang#75637 (update stacker to 0.1.11 to unbreak build for wasm32-unknown-unknown) Failed merges: r? @ghost
Make sure to test file types against the non-canonicalized name to
avoid detecting the wrong type. Some systems save build artifacts
into associate file stores that do not preserve extensions, and
then link to those using conventionally-named symbolic links, that
are the arguments to
rustcet al. If we canonicalize beforetesting the type, we resolve the symlink, the extension is
lost and we might treat rlibs and rmetas as dylibs.
The fix is to tntroduce a temporary to hold the canonicalized name,
compare against the non-canonical name, and add a comment
explaining what's going on for the would-be mainter who sees a
potential cleanup.
Signed-off-by: Dan Cross dcross@google.com