Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: String isn't a collection #75561

Merged
merged 1 commit into from
Aug 16, 2020
Merged

Doc: String isn't a collection #75561

merged 1 commit into from
Aug 16, 2020

Conversation

kornelski
Copy link
Contributor

On forums one user was confused by this text, interpreting it as saying that String is a Vec<char> literally, rather than figuratively for the purpose of collect. I've reworded that paragraph.

@rust-highfive
Copy link
Contributor

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2020
@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

📌 Commit 8d08d5221d76379686455efd2a939ff217ef631f has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2020
@LukasKalbertodt
Copy link
Member

@bors r-

At least the typo should be fixed.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 15, 2020
@kornelski
Copy link
Contributor Author

@LukasKalbertodt done

pickfire
pickfire approved these changes Aug 15, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me.

@LukasKalbertodt
Copy link
Member

Thanks!

@bors r=Dylan-DPC

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

📌 Commit d5cb5eb has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 15, 2020
@bors
Copy link
Collaborator

bors commented Aug 16, 2020

⌛ Testing commit d5cb5eb with merge 243c725...

@bors
Copy link
Collaborator

bors commented Aug 16, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Dylan-DPC
Pushing 243c725 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2020
@bors bors merged commit 243c725 into rust-lang:master Aug 16, 2020
@kornelski kornelski deleted the stringcol branch August 16, 2020 12:59
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
7 participants
@kornelski @rust-highfive @Dylan-DPC-zz @bors @LukasKalbertodt @pickfire @cuviper