Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to intra-doc links in std/src/sys/vxworks/ext/{fs,process}.rs #75565

Merged
merged 4 commits into from
Aug 16, 2020
Merged

Switch to intra-doc links in std/src/sys/vxworks/ext/{fs,process}.rs #75565

merged 4 commits into from
Aug 16, 2020

Conversation

nixphix
Copy link
Contributor

@nixphix nixphix commented Aug 15, 2020

Partial fix for #75080

@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc

r? @jyn514

@rustbot rustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Aug 15, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 15, 2020
jyn514
jyn514 reviewed Aug 15, 2020
View reviewed changes
jyn514
jyn514 approved these changes Aug 15, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once nit is fixed

@nixphix
Copy link
Contributor Author

nixphix commented Aug 15, 2020

@jyn514 I have removed the trailing lines and added inline links

@jyn514
Copy link
Member

jyn514 commented Aug 15, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 15, 2020

📌 Commit c5849ae has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 15, 2020
@bors
Copy link
Collaborator

bors commented Aug 16, 2020

⌛ Testing commit c5849ae with merge de32266...

@bors
Copy link
Collaborator

bors commented Aug 16, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jyn514
Pushing de32266 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 16, 2020
@bors bors merged commit de32266 into rust-lang:master Aug 16, 2020
@nixphix nixphix deleted the docs/vxworks-ext branch August 16, 2020 11:05
@jyn514 jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire left review comments

@jyn514 jyn514 jyn514 approved these changes

Assignees

@jyn514 jyn514

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nixphix @jyn514 @bors @pickfire @cuviper @rust-highfive @rustbot