Clean up AllocRef implementation and documentation #75657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
TimDiekmann
commented
Aug 18, 2020
| // SAFETY: the caller must ensure that the `new_size` does not overflow. | ||
| // `layout.align()` comes from a `Layout` and is thus guaranteed to be valid for a Layout. | ||
| // The caller must ensure that `new_size` is greater than or equal to zero. If it's equal | ||
| // to zero, it's catched beforehand. |
There was a problem hiding this comment.
new_size is always greater than or equal to zero, it's unsigned. Also, it was neither checked, if it's zero before, nor it is required, as self.alloc is well defined for zero-sized layouts. Thus I removed the second part.
Amanieu
reviewed
Aug 18, 2020
Amanieu
reviewed
Aug 18, 2020
|
@bors r+ |
|
📌 Commit 63d241a has been approved by |
bors
added
S-waiting-on-bors
|
Do you think this is likely to have a perf impact? Let me know so I can set rollup=never. |
|
Hmm, I don't think so, but you can rollup=never just to be sure. If there is one, it shouldn't be more than 0.1% at most. |
|
@bors rollup=never |
|
☀️ Test successful - checks-actions, checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Amanieu