Don't panic in Vec::shrink_to_fit #75677
Merged
+40
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can help the compiler see that
Vec::shrink_to_fit
will never reach the panic case inRawVec::shrink_to_fit
, just by guarding the call only for cases where the capacity is strictly greater. A capacity less than the length is only possible through an unsafe call toset_len
, which would break theVec
invariants, soshrink_to_fit
can just ignore that.This removes the panicking code from the examples in both #71861 and #75636.