-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to intra-doc links in /src/sys/unix/ext/*.rs #75685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Aug 19, 2020
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 19, 2020
This is #74489. |
jyn514
reviewed
Aug 19, 2020
@bors r+ rollup |
📌 Commit 63d2e9b has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Aug 19, 2020
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Aug 19, 2020
Switch to intra-doc links in /src/sys/unix/ext/*.rs Partial fix for rust-lang#75080 @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc r? @jyn514 These two links are not resolving to either `crate::fs::File...` or `fs::File...` ``` # unix/ext/fs.rs 27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read 130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write ```
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Aug 19, 2020
Switch to intra-doc links in /src/sys/unix/ext/*.rs Partial fix for rust-lang#75080 @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc r? @jyn514 These two links are not resolving to either `crate::fs::File...` or `fs::File...` ``` # unix/ext/fs.rs 27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read 130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write ```
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Aug 19, 2020
Switch to intra-doc links in /src/sys/unix/ext/*.rs Partial fix for rust-lang#75080 @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc r? @jyn514 These two links are not resolving to either `crate::fs::File...` or `fs::File...` ``` # unix/ext/fs.rs 27: /// [`File::read`]: ../../../../std/fs/struct.File.html#method.read 130: /// [`File::write`]: ../../../../std/fs/struct.File.html#method.write ```
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 19, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#75038 (See also X-Link mem::{swap, take, replace}) - rust-lang#75049 (docs(marker/copy): provide example for `&T` being `Copy`) - rust-lang#75499 (Fix documentation error) - rust-lang#75554 (Fix clashing_extern_declarations stack overflow for recursive types.) - rust-lang#75646 (Move to intra doc links for keyword documentation) - rust-lang#75652 (Resolve true and false as booleans) - rust-lang#75658 (Don't emit "is not a logical operator" error outside of associative expressions) - rust-lang#75665 (Add doc examples coverage) - rust-lang#75685 (Switch to intra-doc links in /src/sys/unix/ext/*.rs) Failed merges: r? @ghost
jyn514
removed
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-docs
Area: documentation for any part of the project, including the compiler, standard library, and tools
A-intra-doc-links
Area: Intra-doc links, the ability to link to items in docs by name
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #75080
@rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
r? @jyn514
These two links are not resolving to either
crate::fs::File...
orfs::File...