Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up E0759 explanation #75702

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Clean up E0759 explanation #75702

merged 2 commits into from
Aug 20, 2020

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2020
pickfire
pickfire reviewed Aug 19, 2020
View reviewed changes
src/librustc_error_codes/error_codes/E0759.md
@@ -5,14 +5,11 @@ Erroneous code examples:
```compile_fail,E0759
use std::fmt::Debug;
Copy link
Contributor

@pickfire pickfire Aug 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still needs Debug? I saw that the rest have the use removed. Oh looks like it is not needed below because it was merged.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

@pickfire
Copy link
Contributor

pickfire commented Aug 19, 2020 •
edited
Loading

A 'static requirement in a return type involving a trait is not fulfilled.

In my humble opinion, I feel like that needs some change to make it easier to read. Maybe?

Return type involving a trait did not require 'static lifetime.

@pickfire
Copy link
Contributor

pickfire commented Aug 19, 2020 •
edited
Loading

These examples have the same semantics as the following:

I feel like that should be changed to something like. I don't understand how "same semantics" is part of the context, I can only see that it is a fix for the above code because of the ok! comment. Maybe?

Add 'static requirement to fix it:

@GuillaumeGomez
Copy link
Member Author

Updated!

pickfire
pickfire approved these changes Aug 20, 2020
View reviewed changes
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@GuillaumeGomez
Copy link
Member Author

@bors: r=pickfire rollup

@bors
Copy link
Contributor

bors commented Aug 20, 2020

📌 Commit 7f55c83 has been approved by pickfire

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2020
@cuviper cuviper mentioned this pull request Aug 20, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 20, 2020
@bors
Auto merge of rust-lang#75747 - cuviper:rollup-icke90l, r=cuviper
3323691 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#75672 (Move to intra-doc links for task.rs and vec.rs)
 - rust-lang#75702 (Clean up E0759 explanation)
 - rust-lang#75703 (Enable stack-overflow detection on musl for non-main threads)
 - rust-lang#75710 (Fix bad printing of const-eval queries)
 - rust-lang#75716 (Upgrade Emscripten on CI to 1.39.20 )
 - rust-lang#75731 (Suppress ty::Float in MIR comments of ty::Const)
 - rust-lang#75733 (Remove duplicated alloc vec bench push_all_move)
 - rust-lang#75743 (Rename rustc_lexer::TokenKind::Not to Bang)

Failed merges:

r? @ghost
@bors bors merged commit ba104d2 into rust-lang:master Aug 20, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0759 branch August 20, 2020 20:45
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickfire pickfire pickfire approved these changes

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @pickfire @bors @cuviper @rust-highfive @Dylan-DPC-zz