-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build aarch64-musl host compiler in CI #75751
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
I assume the PR title "must" is a typo? Can you update this line in the docs to add a checkmark in the third column to indicate this target is available as a host target?
(FWIW, I ran the docker image, and it failed with |
Sigh. Yes, it's a typo. It's a good thing my job doesn't require a lot of typing, I'm quite bad at it. |
51dec79
to
1d3006c
Compare
1d3006c
to
7c152e7
Compare
I've updated the docs. As for the compilation error. #63623 mentions that same error, but doesn't quite find the underlying cause. My inclination is that it likely means the version of GCC being used to build LLVM is too old -- likely since the base docker image is Ubuntu 16.04 and I'm sure aarch64 has improved a lot since then. Is bumping the base container a reasonable thing? |
I don't really know much about it. One thing I don't understand is the difference between |
Thats true. |
Since this moves AArch64 MUSL from Cross-compilation Tier 2 to Development Platform Tier 2, cc @rust-lang/compiler @rustbot modify labels: S-waiting-on-team -S-waiting-on-review |
@ehuss @pietroalbini I think the PR that was closed in favor of this might actually be more complete/better/more functional. I guess I got here first, but I'm very happy to hand it over to @Gelbpunkt unless there's something I missed :-) |
More specifically, I think the T-compiler team was generally in favor of landing this. So I'm removing S-waiting-on-team. (One thing I do not know is whether T-infra has discussed this. Cc @rust-lang/infra ) |
fixes #75721
I've put this together by cargo culting pieces from different Docker files. It's a bit emberassing, because I frankly have no idea if I did this correctly 😬 The docker image builds, but attempting to run it produces various permission errors that I believe are related to my local docker setup by rootless. In short, I'm very sorry for this mess and please review with a critical eye.