Unconfuse Unpin docs a bit #75780

matklad · 2020-08-21T17:52:00Z

Don't say that Unpin is used to prevent moves, because it is used
to allow moves
Be more precise about kindedness of things, it is
Pin<Pointer<Data>>, rather than just Pin<Pointer>.

matklad · 2020-08-21T23:08:12Z

Hm, I wonder what happened with high five here?

r? @withoutboats

Dylan-DPC-zz · 2020-08-22T00:29:02Z

r? @KodrAus

library/core/src/marker.rs

KodrAus · 2020-08-22T10:34:11Z

@rust-highfive left you hanging 😢

But thanks @matklad! This looks good to me.

r=me with @jyn514’s fixes.

* Don't say that Unpin is used to prevent moves, because it is used to *allow* moves * Be more precise about kindedness of things, it is `Pin<Pointer<Data>>`, rather than just `Pin<Pointer>`.

matklad · 2020-08-24T11:57:51Z

@bors r=KodrAus rollup

bors · 2020-08-24T11:57:52Z

📌 Commit daa6620 has been approved by KodrAus

bors · 2020-08-25T14:26:23Z

⌛ Testing commit daa6620 with merge 26d31fcaaa827cecd051f58c15da8995a14d6efd...

rust-log-analyzer · 2020-08-25T14:33:19Z

The job x86_64-msvc-cargo of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

-- Build files have been written to: D:/a/rust/rust/build/x86_64-pc-windows-msvc/llvm/build
running: "cmake" "--build" "." "--target" "install" "--config" "Release" "--" "-j" "8"
[1/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\ABIBreak.cpp.obj
[2/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\Demangle.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/Demangle.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG  /EHs-c- /GR- -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\Demangle.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\Demangle.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\Demangle.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/Demangle.h:12:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\cstddef:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[3/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangleNodes.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangleNodes.cpp.obj 
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangleNodes.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG  /EHs-c- /GR- -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangleNodes.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangleNodes.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangleNodes.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/MicrosoftDemangleNodes.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/StringView.h:17:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\algorithm:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[4/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangle.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.obj 
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG  /EHs-c- /GR- -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\MicrosoftDemangle.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangle.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\MicrosoftDemangle.cpp:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/MicrosoftDemangle.h:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/MicrosoftDemangleNodes.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/StringView.h:17:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\algorithm:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[5/2684] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\ItaniumDemangle.cpp.obj
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/ItaniumDemangle.cpp.obj 
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/ItaniumDemangle.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Demangle -ID:\a\rust\rust\src\llvm-project\llvm\lib\Demangle -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG  /EHs-c- /GR- -std:c++14 /showIncludes /Folib\Demangle\CMakeFiles\LLVMDemangle.dir\ItaniumDemangle.cpp.obj /Fdlib\Demangle\CMakeFiles\LLVMDemangle.dir\LLVMDemangle.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\ItaniumDemangle.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Demangle\ItaniumDemangle.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Demangle/Demangle.h:12:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\cstddef:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[6/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\ARMTargetParser.cpp.obj
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ARMTargetParser.cpp.obj 
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/ARMTargetParser.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -ID:\a\rust\rust\src\llvm-project\llvm\lib\Support -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG -std:c++14  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\ARMTargetParser.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\LLVMSupport.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Support\ARMTargetParser.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Support\ARMTargetParser.cpp:14:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/ARMTargetParser.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/SmallVector.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/iterator_range.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\iterator:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[7/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\AArch64TargetParser.cpp.obj
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AArch64TargetParser.cpp.obj 
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AArch64TargetParser.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -ID:\a\rust\rust\src\llvm-project\llvm\lib\Support -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG -std:c++14  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\AArch64TargetParser.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\LLVMSupport.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AArch64TargetParser.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AArch64TargetParser.cpp:14:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/AArch64TargetParser.h:17:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/SmallVector.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/iterator_range.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\iterator:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[8/2684] Building CXX object lib\Support\CMakeFiles\LLVMSupport.dir\AMDGPUMetadata.cpp.obj
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AMDGPUMetadata.cpp.obj 
FAILED: lib/Support/CMakeFiles/LLVMSupport.dir/AMDGPUMetadata.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Support -ID:\a\rust\rust\src\llvm-project\llvm\lib\Support -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG -std:c++14  /EHs-c- /GR- /showIncludes /Folib\Support\CMakeFiles\LLVMSupport.dir\AMDGPUMetadata.cpp.obj /Fdlib\Support\CMakeFiles\LLVMSupport.dir\LLVMSupport.pdb -c D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AMDGPUMetadata.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\lib\Support\AMDGPUMetadata.cpp:15:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/Twine.h:12:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/SmallVector.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/iterator_range.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\iterator:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
[9/2684] Building CXX object utils\TableGen\CMakeFiles\llvm-tblgen.dir\CodeGenInstruction.cpp.obj
FAILED: utils/TableGen/CMakeFiles/llvm-tblgen.dir/CodeGenInstruction.cpp.obj 
FAILED: utils/TableGen/CMakeFiles/llvm-tblgen.dir/CodeGenInstruction.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iutils\TableGen -ID:\a\rust\rust\src\llvm-project\llvm\utils\TableGen -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG  /EHs-c- /GR- -std:c++14 /showIncludes /Foutils\TableGen\CMakeFiles\llvm-tblgen.dir\CodeGenInstruction.cpp.obj /Fdutils\TableGen\CMakeFiles\llvm-tblgen.dir\ -c D:\a\rust\rust\src\llvm-project\llvm\utils\TableGen\CodeGenInstruction.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\utils\TableGen\CodeGenInstruction.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\utils\TableGen/CodeGenInstruction.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/StringRef.h:12:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/STLExtras.h:19:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/Optional.h:19:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/Compiler.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\new:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
1 error generated.
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\github.com-1ecc6299db9ec823\cmake-0.1.44\src\lib.rs:885:5
 finished in 46.819
failed to run: D:\a\rust\rust\build\bootstrap\debug\bootstrap --stage 2 test src/tools/cargotest src/tools/cargo
Build completed unsuccessfully in 0:02:09
== clock drift check ==
== clock drift check ==
  local time: Tue Aug 25 14:33:03 CUT 2020
  network time: Tue, 25 Aug 2020 14:33:03 GMT
== end clock drift check ==
##[error]Process completed with exit code 1.
Terminate orphan process: pid (732) (node)
Terminate orphan process: pid (6528) (python)
Terminate orphan process: pid (1664) (sccache)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-08-25T14:34:41Z

💔 Test failed - checks-actions

jyn514 · 2020-08-25T14:40:50Z

Well that's odd.

[9/2684] Building CXX object utils\TableGen\CMakeFiles\llvm-tblgen.dir\CodeGenInstruction.cpp.obj
FAILED: utils/TableGen/CMakeFiles/llvm-tblgen.dir/CodeGenInstruction.cpp.obj 
FAILED: utils/TableGen/CMakeFiles/llvm-tblgen.dir/CodeGenInstruction.cpp.obj 
D:\a\rust\rust\build\bootstrap\debug\sccache-plus-cl.exe  /nologo -TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_HAS_EXCEPTIONS=0 -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iutils\TableGen -ID:\a\rust\rust\src\llvm-project\llvm\utils\TableGen -Iinclude -ID:\a\rust\rust\src\llvm-project\llvm\include -nologo -MT -Brepro --target=x86_64-pc-windows-msvc /Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro /W4  -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -Wno-noexcept-type -Wno-comment /Gw /MT /O2 /Ob2 /DNDEBUG  /EHs-c- /GR- -std:c++14 /showIncludes /Foutils\TableGen\CMakeFiles\llvm-tblgen.dir\CodeGenInstruction.cpp.obj /Fdutils\TableGen\CMakeFiles\llvm-tblgen.dir\ -c D:\a\rust\rust\src\llvm-project\llvm\utils\TableGen\CodeGenInstruction.cpp
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
clang-cl: warning: argument unused during compilation: '-Brepro' [-Wunused-command-line-argument]
In file included from D:\a\rust\rust\src\llvm-project\llvm\utils\TableGen\CodeGenInstruction.cpp:13:
In file included from D:\a\rust\rust\src\llvm-project\llvm\utils\TableGen/CodeGenInstruction.h:16:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/StringRef.h:12:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/STLExtras.h:19:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/ADT/Optional.h:19:
In file included from D:\a\rust\rust\src\llvm-project\llvm\include\llvm/Support/Compiler.h:21:
In file included from C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\new:9:
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.27.29110\include\yvals_core.h(494,2): error: STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
#error STL1000: Unexpected compiler version, expected Clang 10.0.0 or newer.
1 error generated.
1 error generated.
ninja: build stopped: subcommand failed.

jyn514 · 2020-08-25T14:41:32Z

Looks like this is https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/MSVC.20on.20CI.20has.20broke.

Dylan-DPC-zz · 2020-08-25T14:51:56Z

seems spurious

@bors retry

@ghost

Rollup of 10 pull requests Successful merges: - rust-lang#74730 (Hexagon libstd: update type defs) - rust-lang#75758 (Fixes for VxWorks) - rust-lang#75780 (Unconfuse Unpin docs a bit) - rust-lang#75806 (Prevent automatic page change when using history) - rust-lang#75818 (Update docs for SystemTime Windows implementation) - rust-lang#75837 (Fix font color for help button in ayu and dark themes) - rust-lang#75870 (Unify theme choices border color in ayu theme) - rust-lang#75875 (Shorten liballoc vec resize intra-doc link) - rust-lang#75953 (Fix swapped stability attributes for rustdoc lints) - rust-lang#75958 (Avoid function-scoping global variables) Failed merges: r? @ghost

rust-highfive assigned withoutboats Aug 21, 2020

rust-highfive assigned KodrAus and unassigned withoutboats Aug 22, 2020

jyn514 reviewed Aug 22, 2020

View reviewed changes

library/core/src/marker.rs Outdated Show resolved Hide resolved

library/core/src/marker.rs Outdated Show resolved Hide resolved

library/core/src/marker.rs Outdated Show resolved Hide resolved

library/core/src/marker.rs Outdated Show resolved Hide resolved

KodrAus reviewed Aug 22, 2020

View reviewed changes

library/core/src/marker.rs Outdated Show resolved Hide resolved

Unconfuse Unpin docs a bit

daa6620

* Don't say that Unpin is used to prevent moves, because it is used to *allow* moves * Be more precise about kindedness of things, it is `Pin<Pointer<Data>>`, rather than just `Pin<Pointer>`.

matklad force-pushed the unconfuseunpindocs branch from d2392e2 to daa6620 Compare August 24, 2020 11:57

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 24, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 25, 2020

Dylan-DPC-zz mentioned this pull request Aug 26, 2020

Rollup of 10 pull requests #75966

Merged

bors merged commit a79f9af into rust-lang:master Aug 27, 2020

jyn514 mentioned this pull request Sep 2, 2020

Use intra-doc links in core::marker #76261

Merged

jyn514 added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Sep 2, 2020

cuviper added this to the 1.48.0 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unconfuse Unpin docs a bit #75780

Unconfuse Unpin docs a bit #75780

matklad commented Aug 21, 2020

matklad commented Aug 21, 2020

Dylan-DPC-zz commented Aug 22, 2020

KodrAus commented Aug 22, 2020

matklad commented Aug 24, 2020

bors commented Aug 24, 2020

bors commented Aug 25, 2020

rust-log-analyzer commented Aug 25, 2020

bors commented Aug 25, 2020

jyn514 commented Aug 25, 2020

jyn514 commented Aug 25, 2020

Dylan-DPC-zz commented Aug 25, 2020

Unconfuse Unpin docs a bit #75780

Unconfuse Unpin docs a bit #75780

Conversation

matklad commented Aug 21, 2020

matklad commented Aug 21, 2020

Dylan-DPC-zz commented Aug 22, 2020

KodrAus commented Aug 22, 2020

matklad commented Aug 24, 2020

bors commented Aug 24, 2020

bors commented Aug 25, 2020

rust-log-analyzer commented Aug 25, 2020

bors commented Aug 25, 2020

jyn514 commented Aug 25, 2020

jyn514 commented Aug 25, 2020

Dylan-DPC-zz commented Aug 25, 2020