Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert core/num/mod.rs to intra-doc links #75807

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Convert core/num/mod.rs to intra-doc links #75807

merged 2 commits into from
Feb 25, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 22, 2020 •
edited
Loading

Helps with #75080.
This can't convert the associated constants MAX and MIN until #74489 is merged.

r? @poliorcetics

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Aug 22, 2020
@jyn514
Copy link
Member Author

jyn514 commented Aug 22, 2020

Highfive seems to be confused this morning .. cc @rust-lang/infra.

@jyn514 jyn514 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 22, 2020
@pietroalbini
Copy link
Member

Highfive is running, it "just" crashed when trying to assign a reviewer. Haven't looked into why it did that.

@jyn514
Copy link
Member Author

jyn514 commented Aug 22, 2020

@pietroalbini @poliorcetics isn't a member of the rust organization, that might be it.

@jyn514 jyn514 mentioned this pull request Aug 22, 2020
Closed
@jyn514
Copy link
Member Author

jyn514 commented Aug 22, 2020

Postponing this until I fix #75809 because I don't want to mess around with concat! and stringify!.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2020
@poliorcetics
Copy link
Contributor

For what its worth, I saw no problems with the current changes once #75809 is fixed.

@LeSeulArtichaut LeSeulArtichaut added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2020
@LeSeulArtichaut
Copy link
Contributor

I guess every PR should have an assignee, so r? @GuillaumeGomez

@jyn514
Copy link
Member Author

jyn514 commented Aug 22, 2020

I could probably just assign myself 😆 but I don't mind either way.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Aug 22, 2020 •
edited
Loading

I don't mind either. :p

As for the concat! and stringify! combo, it was used to have the actual type being used in the examples. That's where the doc-comment crate is coming from. :)

@LeSeulArtichaut
Copy link
Contributor

I don't mind either. :p

Ouf!

@jyn514 jyn514 removed the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 25, 2020
@bors

This comment has been minimized.

Sign in to view
@jyn514
Copy link
Member Author

jyn514 commented Dec 18, 2020

FWIW I'm ok with just not having the Self:: links work with --stage 0 until the bootstrap bump in 2 weeks - the standard library will still compile, some of the links will just silently fail. But I don't mind waiting the two weeks either.

@jyn514 jyn514 mentioned this pull request Dec 30, 2020
Merged
@jyn514
Copy link
Member Author

jyn514 commented Dec 30, 2020

This is ready to go as soon as #79150 lands :) I rebased over it to avoid merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 mentioned this pull request Dec 31, 2020
Closed
@poliorcetics
Copy link
Contributor

#79150 has been merged :)

@jyn514
Copy link
Member Author

jyn514 commented Jan 5, 2021

@poliorcetics this is waiting on #80660 now 😆 so I can automate the switch with cargo intraconv.

@bors

This comment has been minimized.

Sign in to view
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 29, 2021
@camelid
Copy link
Member

camelid commented Jan 29, 2021

I don't think this is blocked any more!

@jyn514
Copy link
Member Author

jyn514 commented Feb 2, 2021

@camelid #80660 landed in 1.51, which is still on nightly.

@jyn514 jyn514 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 2, 2021
@camelid
Copy link
Member

camelid commented Feb 2, 2021

@camelid #80660 landed in 1.51, which is still on nightly.

Dang, I always forget about the bootstrap bump.

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Feb 23, 2021
@jyn514
Copy link
Member Author

jyn514 commented Feb 23, 2021

This is finally ready to land!

@jyn514 jyn514 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2021
poliorcetics
poliorcetics approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@poliorcetics poliorcetics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@jyn514
Copy link
Member Author

jyn514 commented Feb 24, 2021

@bors r=poliorcetics rollup

@bors
Copy link
Contributor

bors commented Feb 24, 2021

📌 Commit ea3118c has been approved by poliorcetics

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2021
LeSeulArtichaut
LeSeulArtichaut approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 25, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 25, 2021
@bors
Auto merge of rust-lang#82517 - Dylan-DPC:rollup-a1958gb, r=Dylan-DPC
0ab7c1d 
Rollup of 16 pull requests

Successful merges:

 - rust-lang#75807 (Convert core/num/mod.rs to intra-doc links)
 - rust-lang#80534 (Use #[doc = include_str!()] in std)
 - rust-lang#80553 (Add an impl of Error on `Arc<impl Error>`.)
 - rust-lang#81167 (Make ptr::write const)
 - rust-lang#81575 (rustdoc: Name fields of `ResolutionFailure::WrongNamespace`)
 - rust-lang#81713 (Account for associated consts in the "unstable assoc item name colission" lint)
 - rust-lang#82078 (Make char and u8 methods const)
 - rust-lang#82087 (Fix ICE caused by suggestion with no code substitutions)
 - rust-lang#82090 (Do not consider using a semicolon inside of a different-crate macro)
 - rust-lang#82213 (Slices for vecs)
 - rust-lang#82214 (Remove redundant to_string calls)
 - rust-lang#82220 (fix the false 'defined here' messages)
 - rust-lang#82313 (Update normalize.css to 8.0.1)
 - rust-lang#82321 (AST: Remove some unnecessary boxes)
 - rust-lang#82364 (Improve error msgs when found type is deref of expected)
 - rust-lang#82514 (Update Clippy)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c9cf922 into rust-lang:master Feb 25, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 25, 2021
@jyn514 jyn514 deleted the num-intra-link branch February 25, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@LeSeulArtichaut LeSeulArtichaut LeSeulArtichaut approved these changes

@poliorcetics poliorcetics poliorcetics approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.52.0
Development

Successfully merging this pull request may close these issues.
9 participants
@jyn514 @pietroalbini @poliorcetics @LeSeulArtichaut @GuillaumeGomez @bors @rust-log-analyzer @camelid @rustbot