publish-toolstate: show more context on HTTP error

[ehuss]

The default display for HTTPError in Python does not include the request body. For GitHub API, the body includes more details about the error (like rate limiting). This could help diagnosing errors like this: #75815 (comment)

[rust-highfive]

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

[Mark-Simulacrum]

Can you confirm this doesn't leak the GitHub token or anything else like that? I suspect no, because it seems to just log the response which IIRC shouldn't contain anything - but would be good to confirm (just looking at what it typically prints is enough IMO).

r=me if so

[ehuss]

Yea, the output is just the JSON object, which looks something like this:

HTTPError: HTTP Error 401: Unauthorized
b'{"message":"Bad credentials","documentation_url":"https://docs.github.com/rest"}'

Another example (from the docs) would be:

HTTP/1.1 403 Forbidden
{
  "message": "Maximum number of login attempts exceeded. Please try again later.",
  "documentation_url": "https://developer.github.com/v3"
}

It does not include any http headers. I'm pretty sure the API never echoes any secrets. Additionally, I believe GitHub Actions (and Azure) have secret scrubbers in the log output which prevents things like GitHub tokens from being exposed.

@bors r=Mark-Simulacrum rollup

[bors]

📌 Commit 2e6f2e8 has been approved by Mark-Simulacrum