-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test that bounds checks are elided for [..index] after .position() #75886
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
This LLVM 11 has improved the performance of my Rust code significantly :-) Biggest jump since years. I don't know why yet. And investigating the causes isn't easy. |
Can you extend the tests for |
I would like to see this changed to min-llvm-version: 11.0.0, as per the comment, and commits squashed. It might be good to also test that rposition() likewise optimizes, which it seems to on LLVM 11. |
ced2250
to
0f1d25e
Compare
@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review |
@bors r+ rollup |
📌 Commit 0f1d25e has been approved by |
Rollup of 10 pull requests Successful merges: - rust-lang#73955 (deny(unsafe_op_in_unsafe_fn) in libstd/process.rs) - rust-lang#75146 (Detect overflow in proc_macro_server subspan) - rust-lang#75304 (Note when a a move/borrow error is caused by a deref coercion) - rust-lang#75749 (Consolidate some duplicate code in the sys modules.) - rust-lang#75882 (Use translated variable for test string) - rust-lang#75886 (Test that bounds checks are elided for [..index] after .position()) - rust-lang#76048 (Initial support for riscv32gc_unknown_linux_gnu) - rust-lang#76198 (Make some Ordering methods const) - rust-lang#76689 (Upgrade to pulldown-cmark 0.8.0) - rust-lang#76763 (Update cargo) Failed merges: r? `@ghost`
Closes #73396.
This was fixed by the LLVM 11 update in #73526.