Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that bounds checks are elided for [..index] after .position() #75886

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

erikdesjardins
Copy link
Contributor

Closes #73396.

This was fixed by the LLVM 11 update in #73526.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 24, 2020
@leonardo-m
Copy link

leonardo-m commented Aug 24, 2020

This LLVM 11 has improved the performance of my Rust code significantly :-) Biggest jump since years. I don't know why yet. And investigating the causes isn't easy.

@tesuji
Copy link
Contributor

tesuji commented Aug 25, 2020

Can you extend the tests for [idx..] ?

@crlf0710
Copy link
Member

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

I would like to see this changed to min-llvm-version: 11.0.0, as per the comment, and commits squashed.

It might be good to also test that rposition() likewise optimizes, which it seems to on LLVM 11.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2020
@erikdesjardins
Copy link
Contributor Author

@rustbot modify labels: -S-waiting-on-author, +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 15, 2020
@nikic
Copy link
Contributor

nikic commented Sep 15, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 15, 2020

📌 Commit 0f1d25e has been approved by nikic

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#73955 (deny(unsafe_op_in_unsafe_fn) in libstd/process.rs)
 - rust-lang#75146 (Detect overflow in proc_macro_server subspan)
 - rust-lang#75304 (Note when a a move/borrow error is caused by a deref coercion)
 - rust-lang#75749 (Consolidate some duplicate code in the sys modules.)
 - rust-lang#75882 (Use translated variable for test string)
 - rust-lang#75886 (Test that bounds checks are elided for [..index] after .position())
 - rust-lang#76048 (Initial support for riscv32gc_unknown_linux_gnu)
 - rust-lang#76198 (Make some Ordering methods const)
 - rust-lang#76689 (Upgrade to pulldown-cmark 0.8.0)
 - rust-lang#76763 (Update cargo)

Failed merges:

r? `@ghost`
@bors bors merged commit 056c7b0 into rust-lang:master Sep 16, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bound checking elided for [index] but not for [..index]