-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applied #![deny(unsafe_op_in_unsafe_fn)]
in library/std/src/wasi
#75971
Applied #![deny(unsafe_op_in_unsafe_fn)]
in library/std/src/wasi
#75971
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with nit fixed and commits squashed
r=me with commits squashed, likely into one |
should I force push them into one? |
Yep! |
All refactoring needed was only in `alloc.rs`, changed part of the code in `alloc` method to satisfy the SAFETY statement
b8d86e2
to
559679b
Compare
@bors r+ |
📌 Commit 559679b has been approved by |
☀️ Test successful - checks-actions, checks-azure |
partial fix for #73904
There are still more that was not applied in mod.rs and that is due to its using files from
../unsupported
like: