Add a StringRef and a VecRef #7599
Conversation
This adds a `VecRef` that can hold either a ~[T] or a &'static [T]
This is the string equivalent of VecRef. I had some trouble with lifetimes trying to implement StrSlice, so I've left it for now, iterating on strings isn't as common and the .as_slice() method merely means you need to add an extra method call.
|
I'm a bit confused about use case. Borrowing a slice exists for just this case, no? Code that can work on both static and dynamic strings... |
|
@graydon: It allows you to have sendable containers of mixed |
|
Related, fail!() accepts both ~str and &'static str by having a trait implemented on both. |
|
Sendable, ok. Fail doesn't seem relevant, it could equally work on a borrowed dynamic slice, no? |
|
looks like a legitimate compilation failure |
|
The |
|
Maybe |
|
I also don't have any use cases for the vector variant of this, so I'm not sure if we want it just to maintain parity with str. |
|
@Aatch needs a rebase |
|
Closing for lack of activity -- @Aatch, feel free to rebase and reopen. |
A SendStr is a string that can hold either a ~str or a &'static str. This can be useful as an optimization when an allocation is sometimes needed but the common case is statically known. Possible use cases include Maps with both static and owned keys, or propagating error messages across task boundaries. SendStr implements most basic traits in a way that hides the fact that it is an enum; in particular things like order and equality are only determined by the content of the wrapped strings. This basically reimplements #7599 and has a use case for replacing an similar type in `std::rt::logging` ( Added in #9180).
…-again, r=llogiq Updating issue templates again for rustbot It turns out that our current issue template can sometimes trigger a rustbot error message, as can be seen in [rust-lang#7626](rust-lang/rust-clippy#7626). I originally tested this in rust-lang#7599, but it's apparently a bit inconsistent. This PR adds backticks to the commands, as correctly suggested by `@mikerite` in the comments. (Thank you!) ``@rustbot` label +S-blocked` --- Now I also pushed a tiny link fix as well. 🙃 --- changelog: none
Adds types for representing either a static string/vector or an owned string/vector.
The vector implements most convenience methods available to other vectors, and the rest can be accessed via the .as_slice() method.
I ran into some issues with the string implementation trying to implement
StrSliceon it, since the borrow checker has difficulty relating the lifetimes. All the standard methods are still available via the .as_slice() method, as before.Both implementations have methods for converting to an owned version, and both have a
to_owned_consumethat consumes the type and only does an allocation if necessary.Closes #6874
PS: I'm not sure on the names, if anybody has any better suggestions, I'm happy to change them.