-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build dist-x86_64-musl with --enable-profiler. #76035
Conversation
Trying to build a Rust project with `-Zprofile` for target x86_64-unknown-linux-musl using rustc 1.46.0-nightly (346aec9 2020-07-11), installed with rustup, results in the following error. ``` export RUSTFLAGS="-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort"export CARGO_INCREMENTAL=0$ cargo build --target=x86_64-unknown-linux-muslCompiling hello_world v0.1.0 (…)error[E0463]: can't find crate for `profiler_builtins` | = note: the compiler may have been built without the profiler runtime error: aborting due to previous error For more information about this error, try `rustc --explain E0463`.error: could not compile `hello_world`. To learn more, run the command again with --verbose. ``` `-Zprofile` is required here to enable grcov profiling. This is similar in nature to issue rust-lang#57257, which has been fixed in asimilar way at rust-lang#60476 . A fix for Android has also landed not long ago: rust-lang#70054 . Signed-off-by: Tiago Lam <tiagol@hadean.com>
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pietroalbini (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@bors r+ rollup=never |
📌 Commit e4bd5cd has been approved by |
☀️ Test successful - checks-actions, checks-azure |
Trying to build a Rust project with
-Zprofile
for targetx86_64-unknown-linux-musl using rustc 1.46.0-nightly (346aec9
2020-07-11), installed with rustup, results in the following error.
-Zprofile
is required here to enable grcov profiling.This is similar in nature to issue
#57257, which has been fixed in
asimilar way at #60476 .
A fix for Android has also landed not long ago:
#70054 .
Signed-off-by: Tiago Lam tiagol@hadean.com