Skip to content

Address review comments about config.toml from rustc-dev-guide PR #76141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2020
Merged

Address review comments about config.toml from rustc-dev-guide PR #76141

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b4a346
Fix incorrect wording for `verbose-tests`
jyn514 Aug 31, 2020
d983873
Document the defaults for `codegen-units`
jyn514 Aug 31, 2020
41c1382
Mention why you'd want codegen-units = 0 (other than running out of RAM)
jyn514 Aug 31, 2020
9f268de
Address review comments
jyn514 Aug 31, 2020
ba664c2
Codegen defaults come from rustc, not cargo
jyn514 Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions config.toml.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,9 @@
# Number of codegen units to use for each compiler invocation. A value of 0
# means "the number of cores on this machine", and 1+ is passed through to the
# compiler.
#codegen-units = 1
#
# Uses the rustc defaults: https://doc.rust-lang.org/rustc/codegen-options/index.html#codegen-units
#codegen-units = if incremental { 256 } else { 16 }

# Sets the number of codegen units to build the standard library with,
# regardless of what the codegen-unit setting for the rest of the compiler is.
Expand Down Expand Up @@ -392,7 +394,7 @@
# desired in distributions, for example.
#rpath = true

# Emits extra output from tests so test failures are debuggable just from logfiles.
# Prints each test name as it is executed, to help debug issues in the test harness itself.
#verbose-tests = false

# Flag indicating whether tests are compiled with optimizations (the -O flag).
Expand Down