Improve recovery on malformed format call #76160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
petrochenkov
added
S-waiting-on-author
scrabsha
force-pushed
the
format-recovery
branch
from
c49909b to
cfe7a90
Compare
scrabsha
commented
Sep 1, 2020
scrabsha
force-pushed
the
format-recovery
branch
from
cfe7a90 to
e982ae5
Compare
petrochenkov
added
S-waiting-on-review
scrabsha
force-pushed
the
format-recovery
branch
from
e982ae5 to
1f1f206
Compare
|
@bors r+ |
|
📌 Commit 1f1f206db2b8b3c730c6800148a4f121436a06ef has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 1f1f206db2b8b3c730c6800148a4f121436a06ef with merge e8f5f5f2644fecb829b1e99362862303d2bd1847... |
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
|
Looks like one of UI tests wasn't updated. |
petrochenkov
added
S-waiting-on-author
If a comma in a format call is replaced with a similar token, then we emit an error and continue parsing, instead of stopping at this point.
scrabsha
force-pushed
the
format-recovery
branch
from
1f1f206 to
3524c3e
Compare
This has been fixed in my last force-push. |
|
@bors r+ |
|
📌 Commit 3524c3e has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
ghost
mentioned this pull request
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Sep 3, 2020
Update ui stderr with improved rustc output Related rust pull request: rust-lang/rust#76160 changelog: none
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 10, 2020
Improve recovery on malformed format call The token following a format expression should be a comma. However, when it is replaced with a similar token (such as a dot), then the corresponding error is emitted, but the token is treated as a comma, and the parsing step continues. r? @petrochenkov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The token following a format expression should be a comma. However, when it is replaced with a similar token (such as a dot), then the corresponding error is emitted, but the token is treated as a comma, and the parsing step continues.
r? @petrochenkov