Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MMX from Rust #76295

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Remove MMX from Rust #76295

merged 1 commit into from
Sep 21, 2020

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Sep 3, 2020 •
edited
Loading

Follow-up to rust-lang/stdarch#890
This removes most of MMX from Rust (tests pass with small changes), keeping stable is_x86_feature_detected!("mmx") working.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2020
@mati865
Copy link
Contributor Author

mati865 commented Sep 3, 2020

cc @Amanieu

@jyn514 jyn514 added the A-codegen Area: Code generation label Sep 3, 2020
@mati865
Copy link
Contributor Author

mati865 commented Sep 4, 2020

Updated, I'll squash commits afterwards.

@mati865 mati865 marked this pull request as ready for review September 4, 2020 08:13
@bors

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 15, 2020

☔ The latest upstream changes (presumably #73166) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

This was referenced Sep 19, 2020
Closed
Closed
@danieldjewell
Copy link

Can someone please double check the above referenced issues in rust-lang/packed_simd and ripgrep? If these changes did make it into nightly on 2020-09-15 then this change would appear to be the root cause of the compilation failures.

@Amanieu
Copy link
Member

Amanieu commented Sep 19, 2020

LGTM but probably needs a sign-off from @rust-lang/compiler.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 20, 2020

@bors r=Amanieu,oli-obk

@bors
Copy link
Contributor

bors commented Sep 20, 2020

📌 Commit 4f8e1c60aa5e1eb2f43f93021d9d1e2da6ac4ae9 has been approved by Amanieu,oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2020
@mati865
Copy link
Contributor Author

mati865 commented Sep 20, 2020

Don't you want me to squash commits first?

I left them to make review easier but this causes mess in git history.

@oli-obk
Copy link
Contributor

oli-obk commented Sep 20, 2020

@bors r-

@bors delegate+

Sure, feel free to r=Amanieu,oli-obk after squashing

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2020
@bors
Copy link
Contributor

bors commented Sep 20, 2020

✌️ @mati865 can now approve this pull request

@mati865
Copy link
Contributor Author

mati865 commented Sep 20, 2020

@bors r=Amanieu,oli-obk

@bors
Copy link
Contributor

bors commented Sep 20, 2020

📌 Commit 5de2c95 has been approved by Amanieu,oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 20, 2020
@RalfJung
Copy link
Member

@bors rollup=iffy

@bors
Copy link
Contributor

bors commented Sep 21, 2020

⌛ Testing commit 5de2c95 with merge 0f9f0b3...

@bors
Copy link
Contributor

bors commented Sep 21, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Amanieu,oli-obk
Pushing 0f9f0b3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 21, 2020
@bors bors merged commit 0f9f0b3 into rust-lang:master Sep 21, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 21, 2020
@mati865 mati865 deleted the remove-mmx branch September 21, 2020 06:33
@Aaron1011 Aaron1011 mentioned this pull request Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

@nikic nikic nikic left review comments

Assignees

@nikomatsakis nikomatsakis

Labels
A-codegen Area: Code generation merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.