-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 12 pull requests #76322
Rollup of 12 pull requests #76322
Conversation
It is not always obvious that people could see the docs for `&` especially for beginners, it also helps learnability.
To match better naming from proc-macro
These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Move: - `src\test\ui\consts\const-nonzero.rs` to `library\core` - `src\test\ui\consts\ascii.rs` to `library\core` - `src\test\ui\consts\cow-is-borrowed` to `library\alloc` Part of rust-lang#76268
…ing_issues, r=steveklabnik Unstable Book: add links to tracking issues for FFI features
`impl Rc::new_cyclic` References rust-lang#75861 r? @Dylan-DPC
Link vec doc to & reference It is not always obvious that people could see the docs for `&` especially for beginners, it also helps learnability.
…odrAus Use Arc::clone and Rc::clone in documentation This PR replaces uses of `x.clone()` by `Rc::clone(&x)` (or `Arc::clone(&x)`) to better match the documentation for those types. @rustbot modify labels: T-doc
Add missing link in README
Move some Vec UI tests into alloc unit tests A bit of work towards rust-lang#76268, makes a number of the Vec UI tests that are simply running code into unit tests. Ensured that they are being run when testing liballoc locally.
Allow try blocks as the argument to return expressions Fixes rust-lang#76271 I don't think this needs to be edition-aware (phew) since `return try` in 2015 is also the start of an expression, just with a struct literal instead of a block (`return try { x: 4, y: 5 }`).
Rename IsJoint -> Spacing Builds on rust-lang#76286 and might conflict with rust-lang#76285 r? @petrochenkov
Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library` These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
Address review comments on `Peekable::next_if` r? @pickfire See rust-lang#72310 (review) for context.
Link to `#capacity-and-reallocation` when using with_capacity Follow up to rust-lang#76058 (comment). r? @pickfire
Move various ui const tests to `library` Move: - `src\test\ui\consts\const-nonzero.rs` to `library\core` - `src\test\ui\consts\ascii.rs` to `library\core` - `src\test\ui\consts\cow-is-borrowed` to `library\alloc` Part of rust-lang#76268 r? @matklad
📌 Commit 9e1cd5f has been approved by |
⌛ Testing commit 9e1cd5f with merge f5cd213547620d250defdc2fd107f70942ba57e2... |
💔 Test failed - checks-actions |
https://github.com/rust-lang-ci/rust/runs/1071200217#step:23:20475 Seems like the order of tests run by rustdoc changed, but I have no idea what might have caused this |
locally, the test passes :( @jyn514 do you by any chance know what might be the problem here? |
run out of steam for rollups for today, so closing this one! |
It looks like the order rustdoc runs doctests is non-deterministic? I'm not sure why though ... |
Might have something to do with the CI runner having so many cores, I think GitHub Actions has 64 or something insane like that |
Successful merges:
impl Rc::new_cyclic
#75994 (impl Rc::new_cyclic
)Ipv4Addr
andIpv6Addr
const tests unit tests underlibrary
#76299 (MakeIpv4Addr
andIpv6Addr
const tests unit tests underlibrary
)Peekable::next_if
#76302 (Address review comments onPeekable::next_if
)#capacity-and-reallocation
when using with_capacity #76303 (Link to#capacity-and-reallocation
when using with_capacity)library
#76305 (Move various ui const tests tolibrary
)Failed merges:
r? @ghost