-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RLS and Rustfmt #76385
Update RLS and Rustfmt #76385
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Good timing, I just updated this locally as well 😅 I think you also need to set: diff --git a/src/tools/rustc-workspace-hack/Cargo.toml b/src/tools/rustc-workspace-hack/Cargo.toml
index 351e2d4481c..11d61606ff5 100644
--- a/src/tools/rustc-workspace-hack/Cargo.toml
+++ b/src/tools/rustc-workspace-hack/Cargo.toml
@@ -69,7 +69,7 @@ serde = { version = "1.0.82", features = ['derive'] }
serde_json = { version = "1.0.31", features = ["raw_value"] }
smallvec-0_6 = { package = "smallvec", version = "0.6", features = ['union', 'may_dangle'] }
smallvec = { version = "1.0", features = ['union', 'may_dangle'] }
-syn = { version = "1", features = ['fold', 'full', 'extra-traits', 'visit'] }
+syn = { version = "1", features = ['fold', 'full', 'extra-traits', 'visit', 'visit-mut'] }
url = { version = "2.0", features = ['serde'] }
[target.'cfg(not(windows))'.dependencies] since Otherwise r=me |
ahh good spot thanks. I only ran it for rustfmt locally 🤦♂️ |
a44d073
to
1ceb824
Compare
@bors r+ p=1 |
📌 Commit 1ceb824 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
📣 Toolstate changed by #76385! Tested on commit d39b076. 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). |
Tested on commit rust-lang/rust@d39b076. Direct link to PR: <rust-lang/rust#76385> 🎉 rls on windows: build-fail → test-pass (cc @Xanewok). 🎉 rls on linux: build-fail → test-pass (cc @Xanewok). 🎉 rustfmt on windows: build-fail → test-pass (cc @topecongiro @calebcartwright). 🎉 rustfmt on linux: build-fail → test-pass (cc @topecongiro @calebcartwright).
Fixes #76145 and fixes #76146
cc @Xanewok @topecongiro