Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point at named argument not found when using format_args_capture instead of whole format string #76485

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Point at named argument not found when using format_args_capture instead of whole format string #76485

merged 1 commit into from
Sep 26, 2020
+22 −24

Conversation

estebank
Copy link
Contributor

@estebank estebank commented Sep 8, 2020

No description provided.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2020
@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 9, 2020
@crlf0710
Copy link
Member

r? @davidtwco

davidtwco
davidtwco approved these changes Sep 25, 2020
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 25, 2020

📌 Commit 2ac89ff has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2020
This was referenced Sep 25, 2020
Closed
Closed
@jonas-schievink jonas-schievink mentioned this pull request Sep 26, 2020
Closed
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 26, 2020
@RalfJung
Rollup merge of rust-lang#76485 - estebank:format_arg_capture_spans, …
bc9c67f 
…r=davidtwco

Point at named argument not found when using `format_args_capture` instead of whole format string
@RalfJung RalfJung mentioned this pull request Sep 26, 2020
Closed
@bors
Copy link
Contributor

bors commented Sep 26, 2020

⌛ Testing commit 2ac89ff with merge 6f9a8a7...

@bors
Copy link
Contributor

bors commented Sep 26, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: davidtwco
Pushing 6f9a8a7 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 26, 2020
@bors bors merged commit 6f9a8a7 into rust-lang:master Sep 26, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 26, 2020
@estebank estebank deleted the format_arg_capture_spans branch November 9, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

@davidtwco davidtwco davidtwco approved these changes

Assignees

@davidtwco davidtwco

Labels
A-diagnostics Area: Messages for errors, warnings, and lints merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
8 participants
@estebank @rust-highfive @crlf0710 @davidtwco @bors @jyn514 @nikomatsakis @rustbot