use push(char) to add chars (single-char &strs) to strings instead of push_str(&str) #76567

matthiaskrgr · 2020-09-10T12:12:06Z

No description provided.

…seless_format

clippy::single-char-push-str

rust-highfive · 2020-09-10T12:12:10Z

r? @varkor

(rust_highfive has picked a reviewer for you, use r? to override)

varkor · 2020-09-10T16:41:52Z

@bors r+ rollup

bors · 2020-09-10T16:41:54Z

📌 Commit 9bb10cc has been approved by varkor

Rollup of 11 pull requests Successful merges: - rust-lang#75857 (Syntactically permit unsafety on mods) - rust-lang#76289 (Add docs about crate level documentation support) - rust-lang#76514 (Add revisions to const generic issue UI tests.) - rust-lang#76524 (typeck: don't suggest inaccessible private fields) - rust-lang#76548 (Validate removal of AscribeUserType, FakeRead, and Shallow borrow) - rust-lang#76555 (Reword `trivial_casts` lint in rustc book to better explain what it does.) - rust-lang#76559 (add the `const_evaluatable_checked` feature) - rust-lang#76563 (small typo fix in rustc_parse docs) - rust-lang#76565 (take reference to Place directly instead of taking reference to Box<Place>) - rust-lang#76567 (use push(char) to add chars (single-char &strs) to strings instead of push_str(&str)) - rust-lang#76568 (Add missing examples on core traits' method) Failed merges: r? `@ghost`

matthiaskrgr added 3 commits September 10, 2020 13:22

use String::from instead of format!() macro to craft string clippy::u…

e2a511f

…seless_format

don't clone types that are copy (clippy::clone_on_copy)

e11c667

use push(char) instead of push_str(&str) to add single chars to strings

9bb10cc

clippy::single-char-push-str

rust-highfive assigned varkor Sep 10, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 10, 2020

tmandry mentioned this pull request Sep 10, 2020

Rollup of 11 pull requests #76582

Merged

bors merged commit c8f9c72 into rust-lang:master Sep 10, 2020

rustbot added this to the 1.48.0 milestone Sep 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use push(char) to add chars (single-char &strs) to strings instead of push_str(&str) #76567

use push(char) to add chars (single-char &strs) to strings instead of push_str(&str) #76567

matthiaskrgr commented Sep 10, 2020

rust-highfive commented Sep 10, 2020

varkor commented Sep 10, 2020

bors commented Sep 10, 2020

use push(char) to add chars (single-char &strs) to strings instead of push_str(&str) #76567

use push(char) to add chars (single-char &strs) to strings instead of push_str(&str) #76567

Conversation

matthiaskrgr commented Sep 10, 2020

rust-highfive commented Sep 10, 2020

varkor commented Sep 10, 2020

bors commented Sep 10, 2020