Skip to content

Avoid cloning the contents of a TokenStream in a few places #76696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

Avoid cloning the contents of a TokenStream in a few places #76696

merged 1 commit into from
Oct 20, 2020

Conversation

Aaron1011
Copy link
Member

@Aaron1011 Aaron1011 commented Sep 14, 2020 •
edited
Loading

No description provided.

@rust-highfive
Copy link
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2020
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Sep 14, 2020

⌛ Trying commit 02c329a750a8c6ff6316fa53bec0f0fa6cf5005a with merge 1a4f4d775be4bc2c2f5522bc03b96be872f320cd...

@bors
Copy link
Collaborator

bors commented Sep 14, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 1a4f4d775be4bc2c2f5522bc03b96be872f320cd (1a4f4d775be4bc2c2f5522bc03b96be872f320cd)

@rust-timer
Copy link
Collaborator

Queued 1a4f4d775be4bc2c2f5522bc03b96be872f320cd with parent 0b65a3d, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (1a4f4d775be4bc2c2f5522bc03b96be872f320cd): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@Aaron1011 Aaron1011 force-pushed the tokenstream-avoid-clone branch from 02c329a to d7bd3bb Compare October 3, 2020 23:41
@Aaron1011
Copy link
Member Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Collaborator

bors commented Oct 3, 2020

⌛ Trying commit d7bd3bb08a795315a1b7d04c95cccfabc6d6497e with merge b92b6836477f4895834288298fb12e158d4c8cdd...

@bors
Copy link
Collaborator

bors commented Oct 4, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: b92b6836477f4895834288298fb12e158d4c8cdd (b92b6836477f4895834288298fb12e158d4c8cdd)

@rust-timer
Copy link
Collaborator

Queued b92b6836477f4895834288298fb12e158d4c8cdd with parent 25c8c53, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (b92b6836477f4895834288298fb12e158d4c8cdd): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2020
@JohnCSimon
Copy link
Member

merge conflicts

@petrochenkov
Copy link
Contributor

r? @petrochenkov

@rust-highfive rust-highfive assigned petrochenkov and unassigned eddyb Oct 19, 2020
@petrochenkov petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2020
@petrochenkov
Copy link
Contributor

r=me after rebase.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 19, 2020
@Aaron1011 Aaron1011 force-pushed the tokenstream-avoid-clone branch from d7bd3bb to f6aec82 Compare October 19, 2020 16:33
@Aaron1011
Copy link
Member Author

@bors r=petrochenkov

@bors
Copy link
Collaborator

bors commented Oct 19, 2020

📌 Commit f6aec82 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 19, 2020
@bors
Copy link
Collaborator

bors commented Oct 20, 2020

⌛ Testing commit f6aec82 with merge 5546335...

@bors
Copy link
Collaborator

bors commented Oct 20, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: petrochenkov
Pushing 5546335 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 20, 2020
@bors bors merged commit 5546335 into rust-lang:master Oct 20, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Aaron1011 @rust-highfive @rust-timer @bors @JohnCSimon @petrochenkov @eddyb @rustbot