Rewrite TLS to require less usage of @
#7677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\o/ |
|
After @nikomatsakis's comment on #7673, it actually turns out that I can work around the compiler right now in a bit of an odd way to get TLS to not require |
|
Turns out I was able to work around everything completely (with excessive use of Things also changed a fair amount from previously. I'd definitely appreciate someone reading the comments to make sure that I'm still sane. |
|
One unfortunate side effect is that for now |
bors
added a commit
that referenced
this pull request
Jul 12, 2013
cc #6004 and #3273 This is a rewrite of TLS to get towards not requiring `@` when using task local storage. Most of the rewrite is straightforward, although there are two caveats: 1. Changing `local_set` to not require `@` is blocked on #7673 2. The code in `local_pop` is some of the most unsafe code I've written. A second set of eyes should definitely scrutinize it... The public-facing interface currently hasn't changed, although it will have to change because `local_data::get` cannot return `Option<T>`, nor can it return `Option<&T>` (the lifetime isn't known). This will have to be changed to be given a closure which yield `&T` (or as an Option). I didn't do this part of the api rewrite in this pull request as I figured that it could wait until when `@` is fully removed. This also doesn't deal with the issue of using something other than functions as keys, but I'm looking into using static slices (as mentioned in the issues).
|
Awesome, thanks |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 7, 2021
…msteffen fix bug for large_enum_variants Fix the discussion problem in the issue of rust-lang/rust-clippy#7666 (comment) About the false positive problem of case: ```rust enum LargeEnum6 { A, B([u8;255]), C([u8;200]), } ``` changelog: Fix largest_enum_variant wrongly identifying the second largest variant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #6004 and #3273
This is a rewrite of TLS to get towards not requiring
@when using task local storage. Most of the rewrite is straightforward, although there are two caveats:local_setto not require@is blocked on Polymorphically creating traits barely works #7673local_popis some of the most unsafe code I've written. A second set of eyes should definitely scrutinize it...The public-facing interface currently hasn't changed, although it will have to change because
local_data::getcannot returnOption<T>, nor can it returnOption<&T>(the lifetime isn't known). This will have to be changed to be given a closure which yield&T(or as an Option). I didn't do this part of the api rewrite in this pull request as I figured that it could wait until when@is fully removed.This also doesn't deal with the issue of using something other than functions as keys, but I'm looking into using static slices (as mentioned in the issues).