Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allocation information to undefined behaviour errors. #76881

Merged
merged 5 commits into from
Apr 2, 2021
Merged

Add allocation information to undefined behaviour errors. #76881

merged 5 commits into from
Apr 2, 2021

Conversation

hameerabbasi
Copy link
Contributor

@hameerabbasi hameerabbasi commented Sep 18, 2020 •
edited
Loading

So far I'm looking on information on whether the error messages are suitable.

Fixes #53325.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2020
@hameerabbasi
Copy link
Contributor Author

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Sep 18, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Sep 18, 2020

cc @rust-lang/wg-diagnostics

@hameerabbasi hameerabbasi marked this pull request as ready for review September 18, 2020 16:10
@oli-obk
Copy link
Contributor

oli-obk commented Sep 19, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Sep 19, 2020

📌 Commit 25883aa has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#76881 - hameerabbasi:issue-53325, r=oli-obk
34f9501 
Add allocation information to undefined behaviour errors.

So far I'm looking on information on whether the error messages are suitable.

Fixes rust-lang#53325.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#76881 - hameerabbasi:issue-53325, r=oli-obk
7ff0ad1 
Add allocation information to undefined behaviour errors.

So far I'm looking on information on whether the error messages are suitable.

Fixes rust-lang#53325.
This was referenced Sep 19, 2020
Closed
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#76881 - hameerabbasi:issue-53325, r=oli-obk
82e4d6b 
Add allocation information to undefined behaviour errors.

So far I'm looking on information on whether the error messages are suitable.

Fixes rust-lang#53325.
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Sep 19, 2020
Closed
@Dylan-DPC-zz
Copy link

Dylan-DPC-zz commented Sep 20, 2020 •
edited
Loading

failed in rollup

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 20, 2020
@hameerabbasi
Copy link
Contributor Author

hameerabbasi commented Sep 20, 2020 •
edited
Loading

Interesting... All the tests passed locally (I ran ./x.py test). I’ll take another look.

@hameerabbasi
Copy link
Contributor Author

Ahh... Hitting platform-specific errors already. It appears 32-bit platforms have different size allocations and aligns, I'll need to normalize this somehow.

@oli-obk oli-obk mentioned this pull request Sep 20, 2020
Closed
3 tasks
@bors
Copy link
Contributor

bors commented Sep 20, 2020

☔ The latest upstream changes (presumably #74949) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@Dylan-DPC-zz
Copy link

@hameerabbasi any updates on this?

@hameerabbasi
Copy link
Contributor Author

I guess also exclude arm targets...

Since this particular error is too dependent on the target's ABI, I decided to limit the problematic tests to x86_64.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 1, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2021

📌 Commit 49705e0 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2021
@bors
Copy link
Contributor

bors commented Apr 1, 2021

⌛ Testing commit 49705e0 with merge d95895350760c80709aca44c2887b0922df1d664...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@hameerabbasi
Copy link
Contributor Author

The run failed to start AFAICT. Not my fault this time. 😆

@oli-obk
Copy link
Contributor

oli-obk commented Apr 1, 2021

@bors retry

@bors
Copy link
Contributor

bors commented Apr 1, 2021

⌛ Testing commit 49705e0 with merge 5e453bd530c15e42696bec59d1352c15897763c5...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@hameerabbasi
Copy link
Contributor Author

Looks like something else borked the macOS runners. Should we perhaps wait until that's resolved?

@bors
Copy link
Contributor

bors commented Apr 1, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Apr 1, 2021

@bors delegate+

r=me in a few hours

@bors
Copy link
Contributor

bors commented Apr 1, 2021

✌️ @hameerabbasi can now approve this pull request

@hameerabbasi
Copy link
Contributor Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2021
@bors
Copy link
Contributor

bors commented Apr 2, 2021

⌛ Testing commit 49705e0 with merge 23fa536...

@bors
Copy link
Contributor

bors commented Apr 2, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 23fa536 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 2, 2021
@bors bors merged commit 23fa536 into rust-lang:master Apr 2, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 2, 2021
@infinity0 infinity0 mentioned this pull request Oct 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorn3 bjorn3 bjorn3 left review comments

@estebank estebank estebank left review comments

@oli-obk oli-obk Awaiting requested review from oli-obk

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Show a constant's virtual memory on validation errors