Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: move cold path of process_obligations into a separate function #77041

Merged
merged 1 commit into from
Sep 25, 2020
Merged

perf: move cold path of process_obligations into a separate function #77041

merged 1 commit into from
Sep 25, 2020
+27 −18

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 22, 2020 •
edited
Loading

cc #76575

This probably won't matter too much in the long run once #69218 is merged so we may not want to merge this.

r? @ecstatic-morse

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2020
@lcnr
Copy link
Contributor Author

lcnr commented Sep 22, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Sep 22, 2020

⌛ Trying commit 8f7c42bf82ac9649f17b2d709b30264d535338c4 with merge 3943bf088dc91b49ad11f4b16e68f7831e71355a...

@bors
Copy link
Contributor

bors commented Sep 22, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 3943bf088dc91b49ad11f4b16e68f7831e71355a (3943bf088dc91b49ad11f4b16e68f7831e71355a)

@rust-timer
Copy link
Collaborator

Queued 3943bf088dc91b49ad11f4b16e68f7831e71355a with parent 4519845, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (3943bf088dc91b49ad11f4b16e68f7831e71355a): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@lcnr lcnr force-pushed the const-eval-perf branch 2 times, most recently from e0914f4 to 923b1da Compare September 22, 2020 17:14
@lcnr
Copy link
Contributor Author

lcnr commented Sep 22, 2020

let's try something else...

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Sep 22, 2020

⌛ Trying commit 923b1da2976f355926bea98490a8323e031642cb with merge 6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52...

@bors
Copy link
Contributor

bors commented Sep 22, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52 (6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52)

@rust-timer
Copy link
Collaborator

Queued 6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52 with parent e0bc267, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6f082f365d7cd6b5ca1cb5b85ca89a795d85ff52): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@lcnr
Copy link
Contributor Author

lcnr commented Sep 24, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Sep 24, 2020

⌛ Trying commit f0c3c6439d9e42aa2d158728e8d79eb2fec79615 with merge 6b31c91ac8796e36a3f86a5feec9b5a78517bfc7...

@bors
Copy link
Contributor

bors commented Sep 24, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 6b31c91ac8796e36a3f86a5feec9b5a78517bfc7 (6b31c91ac8796e36a3f86a5feec9b5a78517bfc7)

@rust-timer
Copy link
Collaborator

Queued 6b31c91ac8796e36a3f86a5feec9b5a78517bfc7 with parent 87d262a, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (6b31c91ac8796e36a3f86a5feec9b5a78517bfc7): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@lcnr lcnr changed the title [DO NOT MERGE] perf tests for #76575 perf: move cold path of process_obligations into a separate function Sep 24, 2020
@lcnr
Copy link
Contributor Author

lcnr commented Sep 24, 2020

@bors try @rust-timer queue

@bors
Copy link
Contributor

bors commented Sep 24, 2020

⌛ Trying commit 06d2325 with merge 74f84cdf746e754004f0df926a23c1d5c9113b77...

@bors
Copy link
Contributor

bors commented Sep 24, 2020

☀️ Try build successful - checks-actions, checks-azure
Build commit: 74f84cdf746e754004f0df926a23c1d5c9113b77 (74f84cdf746e754004f0df926a23c1d5c9113b77)

@lcnr
Copy link
Contributor Author

lcnr commented Sep 24, 2020

Was rust-perf down?

@rust-timer build 74f84cdf746e754004f0df926a23c1d5c9113b77

@rust-timer
Copy link
Collaborator

Queued 74f84cdf746e754004f0df926a23c1d5c9113b77 with parent e599b53, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (74f84cdf746e754004f0df926a23c1d5c9113b77): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never

@ecstatic-morse
Copy link
Contributor

ecstatic-morse commented Sep 24, 2020 •
edited
Loading

Really nice work here @lcnr. I'll cc @Marwes since maybe they can do (or have done) something similar in #69218.

r=me once you're happy.

@lcnr
Copy link
Contributor Author

lcnr commented Sep 25, 2020

hmm, yeah

Let's just merge this, rebasing #69218 on top of this hopefully won't be an issue. Probably only useful for a few days though, considering that #69218 makes these changes obsolete, as the outer loop won't exist anymore.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Sep 25, 2020

📌 Commit 06d2325 has been approved by lcnr

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2020
@lcnr
Copy link
Contributor Author

lcnr commented Sep 25, 2020

@bors r-
@bors r=ecstatic-morse

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 25, 2020
@bors
Copy link
Contributor

bors commented Sep 25, 2020

📌 Commit 06d2325 has been approved by ecstatic-morse

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 25, 2020
@bors
Copy link
Contributor

bors commented Sep 25, 2020

⌛ Testing commit 06d2325 with merge 521d8d8...

@bors
Copy link
Contributor

bors commented Sep 25, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: ecstatic-morse
Pushing 521d8d8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 25, 2020
@bors bors merged commit 521d8d8 into rust-lang:master Sep 25, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 25, 2020
@lcnr lcnr deleted the const-eval-perf branch September 25, 2020 12:32
@ecstatic-morse ecstatic-morse mentioned this pull request Sep 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ecstatic-morse ecstatic-morse

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lcnr @rust-timer @bors @ecstatic-morse @rust-highfive @rustbot