Add a lint to detect unnecessarily qualified names #7706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've seen very bad things that happen to lints which are turned off by default. They very quickly bitrot and start turning up false positives or are just generally not very useful (so no one ends up turning it on). I think the best way to prevent this is to add some tests to compile-fail exercising this lint mode. |
|
Added a test. |
bors
added a commit
that referenced
this pull request
Jul 12, 2013
Fix #2551. Lint is off by default because I didn't bother to fix all of std and extra.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…rednet Fix `unsound_collection_transmute` fixes rust-lang#7706 changelog: Better check size and alignment requirements in `unsound_collection_transmute`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2551.
Lint is off by default because I didn't bother to fix all of std and extra.