Fix recursive nonterminal expansion during pretty-print/reparse check #77153

Aaron1011 · 2020-09-24T15:44:12Z

Makes progress towards #43081

In PR #73084, we started recursively expanded nonterminals during the
pretty-print/reparse check, allowing them to be properly compared
against the reparsed tokenstream.

Unfortunately, the recursive logic in that PR only handles the case
where a nonterminal appears inside a TokenTree::Delimited. If a
nonterminal appears directly in the expanded tokens of another
nonterminal, the inner nonterminal will not be expanded.

This PR fixes the recursive expansion of nonterminals, ensuring that
they are expanded wherever they occur.

rust-highfive · 2020-09-24T15:44:16Z

r? @lcnr

(rust_highfive has picked a reviewer for you, use r? to override)

Aaron1011 · 2020-09-24T15:44:59Z

PR #73084 caused an enormous amount of breakage, so let's do a Crater run.

@bors try

bors · 2020-09-24T15:45:11Z

⌛ Trying commit 1ece537bc9a36cab105dc10f5bfb66477cb83692 with merge 5d9095c550fcec9e458ce8d6b0c04a217641db66...

lcnr · 2020-09-24T15:52:16Z

not something I am qualified to review

r? @petrochenkov

bors · 2020-09-24T16:31:10Z

☀️ Try build successful - checks-actions, checks-azure
Build commit: 5d9095c550fcec9e458ce8d6b0c04a217641db66 (5d9095c550fcec9e458ce8d6b0c04a217641db66)

Aaron1011 · 2020-09-24T17:33:58Z

@craterbot check

craterbot · 2020-09-24T17:34:03Z

👌 Experiment pr-77153 created and queued.
🤖 Automatically detected try build 5d9095c550fcec9e458ce8d6b0c04a217641db66
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-09-24T18:08:18Z

🚧 Experiment pr-77153 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

compiler/rustc_parse/src/lib.rs

petrochenkov · 2020-09-24T20:22:57Z

LGTM, waiting on crater run.

craterbot · 2020-09-26T00:36:41Z

🚨 Experiment pr-77153 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Aaron1011 · 2020-09-26T17:10:32Z

@craterbot retry

craterbot · 2020-09-26T17:10:33Z

🛠️ Experiment pr-77153 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-09-26T17:13:39Z

🚧 Experiment pr-77153 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2020-09-28T20:33:38Z

🎉 Experiment pr-77153 is completed!
📊 18 regressed and 7 fixed (123308 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Your crate has several transitive dependencies that use an old version of the `syn` crate. In future versions of Rust (in particular, once rust-lang/rust#77153) is merged), this may cause your crate to stop compiling. Fortunately, all of these crates have newer versions available when depend on newer versions of `syn`. I've updated these crates in your `Cargo.lock`, which will allow your crate to compile on both older and newer versions of Rust.

Aaron1011 · 2020-09-28T22:42:44Z

Regressions triaged at https://hackmd.io/_2g75FenRUGYDhz5vYSupQ

Most of them just required syn to be bumped to a version that can handle None-delimited groups.

I found two more unhygienic macros. One was an internal helper macro (fixed in eHealthExperts/k2-creek#40).

More concerning, the second unhygienic macro is the derive_more crate. It currently using syn::parse_str(tokenstream.to_string()) in a few places, which throws away hygiene information. I PR's a fix in JelteF/derive_more#144, but this could result in downstream breakage independent of this PR.

Makes progress towards rust-lang#43081 In PR rust-lang#73084, we started recursively expanded nonterminals during the pretty-print/reparse check, allowing them to be properly compared against the reparsed tokenstream. Unfortunately, the recursive logic in that PR only handles the case where a nonterminal appears inside a `TokenTree::Delimited`. If a nonterminal appears directly in the expanded tokens of another nonterminal, the inner nonterminal will not be expanded. This PR fixes the recursive expansion of nonterminals, ensuring that they are expanded wherever they occur.

Your `Cargo.lock` is currently locking an old version of the `syn` crate. In future versions of Rust (in particular, once rust-lang/rust#77153) is merged), this may cause your crate to stop compiling. This PR bumps `syn` to the latest version in your `Cargo.lock`. This ensures that your crate can compiler with both older and newer versions of Rust.

petrochenkov · 2020-09-29T16:47:15Z

I'm basically ready to merge this since the number of regressions is not large and no regressions are caused by issues in rustc.
Alternatively, we could wait for crater results in #77135 and land the both changes together.

Aaron1011 · 2020-09-29T16:49:59Z

@petrochenkov: I'd like to wait for JelteF/derive_more#144 to be merged, so that there's an upgrade path available for all crates known to be affected.

petrochenkov · 2020-09-29T16:56:56Z

Ok, marking as blocked then.

Aaron1011 · 2020-09-30T19:23:19Z

@petrochenkov: My derive_more PR has been merged, and a new release has been made. There's now an upgrade path for all known regressions.

This PR should be ready to merge.

petrochenkov · 2020-09-30T21:04:19Z

@bors r+

bors · 2020-09-30T21:04:20Z

📌 Commit 46d8c4b has been approved by petrochenkov

Rollup of 12 pull requests Successful merges: - rust-lang#76909 (Add Iterator::advance_by and DoubleEndedIterator::advance_back_by) - rust-lang#77153 (Fix recursive nonterminal expansion during pretty-print/reparse check) - rust-lang#77202 (Defer Apple SDKROOT detection to link time.) - rust-lang#77303 (const evaluatable: improve `TooGeneric` handling) - rust-lang#77305 (move candidate_from_obligation_no_cache) - rust-lang#77315 (Rename AllocErr to AllocError) - rust-lang#77319 (Stable hashing: add comments and tests concerning platform-independence) - rust-lang#77324 (Don't fire `const_item_mutation` lint on writes through a pointer) - rust-lang#77343 (Validate `rustc_args_required_const`) - rust-lang#77349 (Update cargo) - rust-lang#77360 (References to ZSTs may be at arbitrary aligned addresses) - rust-lang#77371 (Remove trailing space in error message) Failed merges: r? `@ghost`

tesuji · 2020-10-01T01:44:19Z

Does this PR need tagging relnotes ?

Clean up some of the pkgsrc Makefile, there's still lots in here that should just be deleted though. Switch SunOS to the illumos bootstrap by default. Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.][77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

Pkgsrc changes: * Compensate for files being moved around upstream. * Introduce optional, on-by-default semi-static building of cargo, using the internal curl and openssl sources. This reduces the dynamic dependencies of cargo and therefore the rust package itself. Ref. options.mk. * The 1.47.0 bootstrap kits have been re-built with the above option turned on, so no longer depends on curl or openssl from pkgsrc and/or from earlier OS or pkgsrc versions. This should hopefully fix installation of rust with non-default PREFIX, ref. PR#54453. Upstream changes: Version 1.48.0 (2020-11-19) ========================== Language -------- - [The `unsafe` keyword is now syntactically permitted on modules.][75857] This is still rejected *semantically*, but can now be parsed by procedural macros. Compiler -------- - [Stabilised the `-C link-self-contained=<yes|no>` compiler flag.][76158] This tells `rustc` whether to link its own C runtime and libraries or to rely on a external linker to find them. (Supported only on `windows-gnu`, `linux-musl`, and `wasi` platforms.) - [You can now use `-C target-feature=+crt-static` on `linux-gnu` targets.] [77386] Note: If you're using cargo you must explicitly pass the `--target` flag. - [Added tier 2\* support for `aarch64-unknown-linux-musl`.][76420] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. Libraries --------- - [`io::Write` is now implemented for `&ChildStdin` `&Sink`, `&Stdout`, and `&Stderr`.][76275] - [All arrays of any length now implement `TryFrom<Vec<T>>`.][76310] - [The `matches!` macro now supports having a trailing comma.][74880] - [`Vec<A>` now implements `PartialEq<[B]>` where `A: PartialEq<B>`.][74194] - [The `RefCell::{replace, replace_with, clone}` methods now all use `#[track_caller]`.][77055] Stabilized APIs --------------- - [`slice::as_ptr_range`] - [`slice::as_mut_ptr_range`] - [`VecDeque::make_contiguous`] - [`future::pending`] - [`future::ready`] The following previously stable methods are now `const fn`'s: - [`Option::is_some`] - [`Option::is_none`] - [`Option::as_ref`] - [`Result::is_ok`] - [`Result::is_err`] - [`Result::as_ref`] - [`Ordering::reverse`] - [`Ordering::then`] Cargo ----- Rustdoc ------- - [You can now link to items in `rustdoc` using the intra-doc link syntax.][74430] E.g. ``/// Uses [`std::future`]`` will automatically generate a link to `std::future`'s documentation. See ["Linking to items by name"][intradoc-links] for more information. - [You can now specify `#[doc(alias = "<alias>")]` on items to add search aliases when searching through `rustdoc`'s UI.][75740] Compatibility Notes ------------------- - [Promotion of references to `'static` lifetime inside `const fn` now follows the same rules as inside a `fn` body.][75502] In particular, `&foo()` will not be promoted to `'static` lifetime any more inside `const fn`s. - [Associated type bindings on trait objects are now verified to meet the bounds declared on the trait when checking that they implement the trait.][27675] - [When trait bounds on associated types or opaque types are ambiguous, the compiler no longer makes an arbitrary choice on which bound to use.][54121] - [Fixed recursive nonterminals not being expanded in macros during pretty-print/reparse check.][77153] This may cause errors if your macro wasn't correctly handling recursive nonterminal tokens. - [`&mut` references to non zero-sized types are no longer promoted.][75585] - [`rustc` will now warn if you use attributes like `#[link_name]` or `#[cold]` in places where they have no effect.][73461] - [Updated `_mm256_extract_epi8` and `_mm256_extract_epi16` signatures in `arch::{x86, x86_64}` to return `i32` to match the vendor signatures.][73166] - [`mem::uninitialized` will now panic if any inner types inside a struct or enum disallow zero-initialization.][71274] - [`#[target_feature]` will now error if used in a place where it has no effect.][78143] - [Foreign exceptions are now caught by `catch_unwind` and will cause an abort.][70212] Note: This behaviour is not guaranteed and is still considered undefined behaviour, see the [`catch_unwind`] documentation for further information. Internal Only ------------- These changes provide no direct user facing benefits, but represent significant improvements to the internals and overall performance of rustc and related tools. - [Building `rustc` from source now uses `ninja` by default over `make`.][74922] You can continue building with `make` by setting `ninja=false` in your `config.toml`. - [cg_llvm: `fewer_names` in `uncached_llvm_type`][76030] - [Made `ensure_sufficient_stack()` non-generic][76680] [78143]: rust-lang/rust#78143 [76680]: rust-lang/rust#76680 [76030]: rust-lang/rust#76030 [70212]: rust-lang/rust#70212 [27675]: rust-lang/rust#27675 [54121]: rust-lang/rust#54121 [71274]: rust-lang/rust#71274 [77386]: rust-lang/rust#77386 [77153]: rust-lang/rust#77153 [77055]: rust-lang/rust#77055 [76275]: rust-lang/rust#76275 [76310]: rust-lang/rust#76310 [76420]: rust-lang/rust#76420 [76158]: rust-lang/rust#76158 [75857]: rust-lang/rust#75857 [75585]: rust-lang/rust#75585 [75740]: rust-lang/rust#75740 [75502]: rust-lang/rust#75502 [74880]: rust-lang/rust#74880 [74922]: rust-lang/rust#74922 [74430]: rust-lang/rust#74430 [74194]: rust-lang/rust#74194 [73461]: rust-lang/rust#73461 [73166]: rust-lang/rust#73166 [intradoc-links]: https://doc.rust-lang.org/rustdoc/linking-to-items-by-name.html [`catch_unwind`]: https://doc.rust-lang.org/std/panic/fn.catch_unwind.html [`Option::is_some`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some [`Option::is_none`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.is_none [`Option::as_ref`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.as_ref [`Result::is_ok`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_ok [`Result::is_err`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.is_err [`Result::as_ref`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.as_ref [`Ordering::reverse`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.reverse [`Ordering::then`]: https://doc.rust-lang.org/std/cmp/enum.Ordering.html#method.then [`slice::as_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_ptr_range [`slice::as_mut_ptr_range`]: https://doc.rust-lang.org/std/primitive.slice.html#method.as_mut_ptr_range [`VecDeque::make_contiguous`]: https://doc.rust-lang.org/std/collections/struct.VecDeque.html#method.make_contiguous [`future::pending`]: https://doc.rust-lang.org/std/future/fn.pending.html [`future::ready`]: https://doc.rust-lang.org/std/future/fn.ready.html

rust-highfive assigned lcnr Sep 24, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2020

rust-highfive assigned petrochenkov and unassigned lcnr Sep 24, 2020

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2020

petrochenkov added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2020

petrochenkov reviewed Sep 24, 2020

View reviewed changes

compiler/rustc_parse/src/lib.rs Outdated Show resolved Hide resolved

petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2020

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 28, 2020

Aaron1011 mentioned this pull request Sep 28, 2020

Bump failure_derive, serde_derive, and pest_generator dependencies stephenc/dns-watch#1

Open

Aaron1011 mentioned this pull request Sep 28, 2020

Bump failure_derive and synstruture dependencies vendemiat/dnssec_verifier#1

Open

Aaron1011 mentioned this pull request Sep 28, 2020

Fix hygiene of test! macro eHealthExperts/k2-creek#40

Closed

Aaron1011 force-pushed the fix/better-recursive-expand branch from 1ece537 to 46d8c4b Compare September 28, 2020 23:15

Aaron1011 mentioned this pull request Sep 29, 2020

Refactor AST pretty-printing to allow skipping insertion of extra parens #77135

Merged

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2020

petrochenkov added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 29, 2020

Aaron1011 mentioned this pull request Sep 29, 2020

Avoid stringifying and reparsing a TokenStream JelteF/derive_more#144

Merged

Aaron1011 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 30, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2020

Dylan-DPC-zz mentioned this pull request Oct 1, 2020

Rollup of 12 pull requests #77381

Merged

Aaron1011 added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 1, 2020

bors merged commit 8ccc063 into rust-lang:master Oct 1, 2020

rustbot added this to the 1.48.0 milestone Oct 1, 2020

SNCPlay42 mentioned this pull request Nov 21, 2020

Rustc hangs on recursive macro expansion on 1.48.0 #79242

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix recursive nonterminal expansion during pretty-print/reparse check #77153

Fix recursive nonterminal expansion during pretty-print/reparse check #77153

Aaron1011 commented Sep 24, 2020

rust-highfive commented Sep 24, 2020

Aaron1011 commented Sep 24, 2020

bors commented Sep 24, 2020

lcnr commented Sep 24, 2020

bors commented Sep 24, 2020

Aaron1011 commented Sep 24, 2020

craterbot commented Sep 24, 2020

craterbot commented Sep 24, 2020

petrochenkov commented Sep 24, 2020

craterbot commented Sep 26, 2020

Aaron1011 commented Sep 26, 2020

craterbot commented Sep 26, 2020

craterbot commented Sep 26, 2020

craterbot commented Sep 28, 2020

Aaron1011 commented Sep 28, 2020

petrochenkov commented Sep 29, 2020 •

edited

Loading

Aaron1011 commented Sep 29, 2020 •

edited

Loading

petrochenkov commented Sep 29, 2020

Aaron1011 commented Sep 30, 2020

petrochenkov commented Sep 30, 2020

bors commented Sep 30, 2020

tesuji commented Oct 1, 2020

Fix recursive nonterminal expansion during pretty-print/reparse check #77153

Fix recursive nonterminal expansion during pretty-print/reparse check #77153

Conversation

Aaron1011 commented Sep 24, 2020

rust-highfive commented Sep 24, 2020

Aaron1011 commented Sep 24, 2020

bors commented Sep 24, 2020

lcnr commented Sep 24, 2020

bors commented Sep 24, 2020

Aaron1011 commented Sep 24, 2020

craterbot commented Sep 24, 2020

craterbot commented Sep 24, 2020

petrochenkov commented Sep 24, 2020

craterbot commented Sep 26, 2020

Aaron1011 commented Sep 26, 2020

craterbot commented Sep 26, 2020

craterbot commented Sep 26, 2020

craterbot commented Sep 28, 2020

Aaron1011 commented Sep 28, 2020

petrochenkov commented Sep 29, 2020 • edited Loading

Aaron1011 commented Sep 29, 2020 • edited Loading

petrochenkov commented Sep 29, 2020

Aaron1011 commented Sep 30, 2020

petrochenkov commented Sep 30, 2020

bors commented Sep 30, 2020

tesuji commented Oct 1, 2020

petrochenkov commented Sep 29, 2020 •

edited

Loading

Aaron1011 commented Sep 29, 2020 •

edited

Loading