-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in vec doc "tries to reserves" #77192
Conversation
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you have a bunch of improvements like this I would personally prefer to see a single PR rather than tiny PRs, easier to review in batches. (And less commits editing docs, better git history, etc.)
Not exactly, I just send these sort of PR once I found it, I don't find it all at once since it is scattered everywhere. But yeah, I have another batch of PR on vec bench but I didn't send it in batch since it is easier to just change the file in github and let others review one by one. But I also don't want to remove a commit if one of the change is not good so I just send it one by one. See #77185 for one of them. But yeah these (this one) PRs are ad-hoc, only those that I ping myself are in batch. |
Co-authored-by: Mark Rousskov <mark.simulacrum@gmail.com>
r=me with commits squashed |
@Mark-Simulacrum Can I create a new pull request for it? I am lazy to rebase. |
I am unopposed. |
Fix typo in vec doc "tries to reserves" Superseeds rust-lang#77192
No description provided.