Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 12 pull requests #77224

Merged
merged 43 commits into from
Sep 26, 2020
Merged

Rollup of 12 pull requests #77224

merged 43 commits into from
Sep 26, 2020

Conversation

RalfJung
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

ltratt and others added 30 commits August 12, 2020 15:07
@ltratt
Explicitly document the size guarantees that Option makes.
73ada2d 
Triggered by a discussion on wg-unsafe-code-guidelines about which layouts of
`Option<T>` one can guarantee are optimised to a single pointer.
@ltratt
Clarify and add guarantee about transmute.
f5118a5
@ltratt
Be clear about the reverse transmute guarantees.
83f47aa
@ltratt
Be clearer about Some/None transmute.
f3d7196
@ltratt @RalfJung
Change notation.
8cb8955 
Co-authored-by: Ralf Jung <post@ralfj.de>
@ltratt @RalfJung
Add Rust function pointers.
55802e3 
Co-authored-by: Ralf Jung <post@ralfj.de>
@ltratt
Rename the types for clarity.
68209c3
@ltratt
Grammar tweak.
9bac577
@lcnr
merge need_type_info_err(_const)
45d92b4
@lcnr
unused path
0abb1ab
@lcnr
use the correct span when dealing with inference variables
3dbfdb0
@lcnr
use relevant span when unifying ConstVarValues
0e84b61
@camelid
Update mdBook
945a732 
0.4.2 -> 0.4.3
@jyn514
Add x.py setup
9baa601 
- Suggest `x.py setup` if config.toml doesn't exist yet (twice, once
before and once after the build)
- Prompt for a profile if not given on the command line
- Print the configuration file that will be used
- Print helpful starting commands after setup
- Link to the dev-guide after finishing
- Note that distro maintainers will see the changelog warning
@est31
Remove TrustedLen requirement from BuilderMethods::switch
12ada5c 
The main use case of TrustedLen is allowing APIs to specialize on it,
but no use of it uses that specialization. Instead, only the .len()
function provided by ExactSizeIterator is used, which is already
required to be accurate.

Thus, the TrustedLen requirement on BuilderMethods::switch is redundant.
@RalfJung
update Miri
47843f5
@lcnr
the two hardest things in programming, names and...
e5430e5
@lcnr
nit
ff7009a
@ecstatic-morse
Add const_fn_floating_point_arithmetic
0d2521a
@ecstatic-morse
Put floating point arithmetic behind its own feature gate
2049052 
This refactors handling of `Rvalue::{Unary,Binary}Op` in the
const-checker. Now we `span_bug` if there's an unexpected type in a
primitive operation. This also allows unary negation on
`char` values through the const-checker because it makes the code a bit
cleaner. `char` does not actually support these operations, and if it
did, we could evaluate them at compile-time.
@ecstatic-morse
Add new feature gate to standard library
6a52c09
@ecstatic-morse
Bless tests
b428f28
@ecstatic-morse
Move const fn floating point test out of min_const_fn
4cac90c
@ecstatic-morse
Use proper issue for const_fn_floating_point_arithmetic
659028f
@GuillaumeGomez
Add missing code examples on slice iter types
187162e
@LingMan
Remove stray word from ClosureKind::extends docs
900daba
@camelid
Rename whence to span
aa6a2f4 
It's called `span` elsewhere in the compiler and `span` is also less
surprising. `whence` is whimsical, but not super clear :)
@est31
Remove unused #[allow(...)] statements from compiler/
12187b7
@lcnr
rename functions
32195ac
@lcnr
unused into
9a607c0
@RalfJung
Rollup merge of rust-lang#77207 - camelid:whence-to-span, r=jyn514
259e947 
Rename `whence` to `span`

It's called `span` elsewhere in the compiler and `span` is also less
surprising. `whence` is whimsical, but not super clear :)

See [this Discord conversation](https://discord.com/channels/442252698964721669/459149231702278154/758731658689511444) for more.

r? @jyn514
@RalfJung
Rollup merge of rust-lang#77211 - est31:remove_unused_allow, r=oli-obk
9e02642 
Remove unused #[allow(...)] statements from compiler/
@RalfJung
Copy link
Member Author

@rustbot modify labels: +rollup
@bors r+ rollup=never p=12

@bors
Copy link
Contributor

bors commented Sep 26, 2020

📌 Commit 9e02642 has been approved by RalfJung

@rustbot rustbot added the rollup A PR which is a rollup label Sep 26, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 26, 2020
@bors
Copy link
Contributor

bors commented Sep 26, 2020

⌛ Testing commit 9e02642 with merge 7351b7f2e5ff5dfdaf71d9fcf728610d35262bff...

@bors
Copy link
Contributor

bors commented Sep 26, 2020

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2020
@rust-log-analyzer
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
##[group]Run exit 1
exit 1
shell: /bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
##[error]Process completed with exit code 1.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@RalfJung
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2020
@bors
Copy link
Contributor

bors commented Sep 26, 2020

⌛ Testing commit 9e02642 with merge e37c99f...

@bors
Copy link
Contributor

bors commented Sep 26, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: RalfJung
Pushing e37c99f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 26, 2020
@bors bors merged commit e37c99f into rust-lang:master Sep 26, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 26, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #77224!

Tested on commit e37c99f.
Direct link to PR: #77224

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 26, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#77224!
767416a 
Tested on commit rust-lang/rust@e37c99f.
Direct link to PR: <rust-lang/rust#77224>

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
This was referenced Sep 26, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@RalfJung RalfJung deleted the rollup-hdvb96c branch September 28, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.