Add missing examples for MaybeUninit #77228
Merged
+16
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
force-pushed
the
maybeuninit-examples
branch
from
0a0cb38 to
3cfd498
Compare
|
ping @Dylan-DPC |
|
r? @pickfire |
pickfire
reviewed
Oct 5, 2020
library/core/src/mem/maybe_uninit.rs
Outdated
| /// ``` | ||
| /// use std::mem::MaybeUninit; | ||
| /// | ||
| /// let v = MaybeUninit::new(vec![42]); |
There was a problem hiding this comment.
Suggested change
| /// let v = MaybeUninit::new(vec![42]); | |
| /// let v: MaybeUninit<Vec<u8>> = MaybeUninit::new(vec![42]); |
Add a type for clarification.
pickfire
suggested changes
Oct 5, 2020
pickfire
reviewed
Oct 5, 2020
| /// | ||
| /// let v = MaybeUninit::new(vec![42]); | ||
| /// ``` | ||
| /// | ||
| /// [`assume_init`]: MaybeUninit::assume_init |
There was a problem hiding this comment.
I feel like removing these links.
pickfire
reviewed
Oct 5, 2020
library/core/src/mem/maybe_uninit.rs
Outdated
| /// | ||
| /// let v: MaybeUninit<String> = MaybeUninit::uninit(); | ||
| /// ``` | ||
| /// | ||
| /// [type]: union.MaybeUninit.html |
There was a problem hiding this comment.
Suggested change
| /// [type]: union.MaybeUninit.html | |
| /// [type]: MaybeUninit |
I think this should work?
GuillaumeGomez
force-pushed
the
maybeuninit-examples
branch
from
3cfd498 to
b1ce619
Compare
|
Let's merge then, thanks for the review! @bors: r=pickfire rollup |
|
📌 Commit b1ce619 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 6, 2020
Rollup of 13 pull requests Successful merges: - rust-lang#76388 (Add a note about the panic behavior of math operations on time objects) - rust-lang#76855 (Revamp rustdoc docs about documentation using `cfg`) - rust-lang#76995 (Reduce boilerplate with the matches! macro) - rust-lang#77228 (Add missing examples for MaybeUninit) - rust-lang#77528 (Avoid unchecked casts in net parser) - rust-lang#77534 (Disallow overriding forbid in same scope) - rust-lang#77555 (Allow anyone to set regression labels) - rust-lang#77558 (Rename bootstrap/defaults/{config.toml.PROFILE => config.PROFILE.toml}) - rust-lang#77559 (Fix rustdoc warnings about invalid Rust syntax) - rust-lang#77560 (Fix LitKind's byte buffer to use refcounted slice) - rust-lang#77573 (Hint doc use convert::identity relative link) - rust-lang#77587 (Fix span for unicode escape suggestion.) - rust-lang#77591 (Record `expansion_that_defined` into crate metadata) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @Dylan-DPC