-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate and generalize some (de/)serializer impls #77261
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 455f284 with merge de1a786a9fd02c206c4260cabc6adf2a40b8d7d1... |
☀️ Try build successful - checks-actions, checks-azure |
Queued de1a786a9fd02c206c4260cabc6adf2a40b8d7d1 with parent c9e5e6a, future comparison URL. |
Finished benchmarking try commit (de1a786a9fd02c206c4260cabc6adf2a40b8d7d1): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
Since this seems good in terms of perf, why not land it? Looks like a reasonable PR to me (without actually knowing all that code^^) |
github reviewer suggestions say |
@bors r+ |
📌 Commit 455f284 has been approved by |
☀️ Test successful - checks-actions, checks-azure |
I noticed this while implementing #77227 and getting a "not implemented for [T; 16]" error. There's likely more things we can deduplicate in this file, but I didn't need any additional changes.