ICEs should always print the top of the query stack #77493

hosseind88 · 2020-10-03T15:52:41Z

rust-highfive · 2020-10-03T15:52:44Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

hosseind88 · 2020-10-03T16:22:31Z

as test failure result instruction, I do ./x.py test --bless --test-args pattern/const-pat-ice.rs
but I get error
anyone knows why? :(

bjorn3 · 2020-10-03T16:30:09Z

src/tools/clippy/tests/ui/custom_ice_message.stderr

@@ -9,3 +9,5 @@ note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy

 note: Clippy version: foo

+query stack during panic:
+we're just showing a limited slice of the query stack


I think it shouldn't say this if all parts of the query stack have been printed. Even when the maximum length is limited.

@bjorn3 so I guess I should normalize it right?
and also when I run the test, it fails, and it deletes the const-pat-ice.stderr file
do you think that we should remove it?

oli-obk · 2020-10-05T09:38:57Z

as test failure result instruction, I do ./x.py test --bless --test-args pattern/const-pat-ice.rs
but I get error

That test does not exist anymore (well, it doesn't ICE anymore). So you should be able to just remove all changes you did around it.

You likely need to rebase over this repository's master branch. I'm not sure what your setup is, but if you invoke git remote -v do you see a rust-lang/rust remote in there? If not, you need to add it with git remote add upstream git@github.com:rust-lang/rust.git and then do git pull --rebase upstream/master. Never rebase over the master branch of your own repository, that will cause a huge mess (I know this, because I've done this a lot in the beginning, too ;) )

hosseind88 · 2020-10-06T15:23:05Z

as test failure result instruction, I do ./x.py test --bless --test-args pattern/const-pat-ice.rs
but I get error

That test does not exist anymore (well, it doesn't ICE anymore). So you should be able to just remove all changes you did around it.

You likely need to rebase over this repository's master branch. I'm not sure what your setup is, but if you invoke git remote -v do you see a rust-lang/rust remote in there? If not, you need to add it with git remote add upstream git@github.com:rust-lang/rust.git and then do git pull --rebase upstream/master. Never rebase over the master branch of your own repository, that will cause a huge mess (I know this, because I've done this a lot in the beginning, too ;) )

thanks, ok I will use this approach

oli-obk · 2020-10-07T06:17:57Z

compiler/rustc_middle/src/ty/query/plumbing.rs

+        if num_frames != None {
+            eprintln!("we're just showing a limited slice of the query stack");
+        } else {
+            eprintln!("end of query stack");
+        }


I think what bjorn3 is suggesting is

Suggested change

if num_frames != None {

eprintln!("we're just showing a limited slice of the query stack");

} else {

eprintln!("end of query stack");

}

if num_frames == None || num_frames >= Some(i) {

eprintln!("end of query stack");

} else {

eprintln!("we're just showing a limited slice of the query stack");

}

but you'll also have to pull out let mut i = 0; so that we have access to i here.

This will make sure end of query stack is printed if there are less than num_frames frames to print.

oli-obk · 2020-10-07T06:19:22Z

After doing all your changes, please use git rebase -i upstream/master and replace all but the first commit's pick with fixup. This will squash all commits down into the first commit.

ThibsG · 2020-10-08T20:53:30Z

Memo: this PR is related to #70953

oli-obk · 2020-10-09T10:06:21Z

compiler/rustc_middle/src/ty/query/plumbing.rs

-        if num_frames != None {
-            eprintln!("we're just showing a limited slice of the query stack");
-        } else {
+        if num_frames == None || num_frames >= Some(i) {


The output did not change... Not sure what's wrong. If num_frames is Some(2) and i is 0, this should return true (according to the playground at least: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=57ab1b6049e331f483455f1ce170e183)

…ack message when RUST_BACKTRACE=0

hosseind88 · 2020-10-12T12:45:20Z

guys anyone has any ideas about it? I thought a lot but I could not find the reason for this issue

oli-obk · 2020-10-12T13:53:05Z

The failing test is a clippy lint, did you run ./x.py test src/tools/clippy?

hosseind88 · 2020-10-14T15:29:07Z

@oli-obk I guess now everything is ok

oli-obk · 2020-10-15T14:01:08Z

@bors r+

great!

bors · 2020-10-15T14:01:10Z

📌 Commit 46cc889 has been approved by oli-obk

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

Rollup of 14 pull requests Successful merges: - rust-lang#75023 (ensure arguments are included in count mismatch span) - rust-lang#75265 (Add `str::{Split,RSplit,SplitN,RSplitN,SplitTerminator,RSplitTerminator,SplitInclusive}::as_str` methods) - rust-lang#75675 (mangling: mangle impl params w/ v0 scheme) - rust-lang#76084 (Refactor io/buffered.rs into submodules) - rust-lang#76119 (Stabilize move_ref_pattern) - rust-lang#77493 (ICEs should always print the top of the query stack) - rust-lang#77619 (Use futex-based thread-parker for Wasm32.) - rust-lang#77646 (For backtrace, use StaticMutex instead of a raw sys Mutex.) - rust-lang#77648 (Static mutex is static) - rust-lang#77657 (Cleanup cloudabi mutexes and condvars) - rust-lang#77672 (Simplify doc-cfg rendering based on the current context) - rust-lang#77780 (rustc_parse: fix spans on cast and range exprs with attrs) - rust-lang#77935 (BTreeMap: make PartialCmp/PartialEq explicit and tested) - rust-lang#77980 (Fix intra doc link for needs_drop) Failed merges: r? `@ghost`

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

rust-highfive assigned oli-obk Oct 3, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 3, 2020

hosseind88 mentioned this pull request Oct 3, 2020

ICEs should print the top of the query stack #76920

Closed

jyn514 changed the title ~~Ic es should always print the top of the query stack~~ ICEs should always print the top of the query stack Oct 3, 2020

jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2020

bjorn3 reviewed Oct 3, 2020

View reviewed changes

hosseind88 force-pushed the ICEs_should_always_print_the_top_of_the_query_stack branch from f3c495f to f3a3c81 Compare October 6, 2020 18:26

oli-obk reviewed Oct 7, 2020

View reviewed changes

oli-obk reviewed Oct 9, 2020

View reviewed changes

hosseind75 added 14 commits October 9, 2020 20:57

ICEs should print the top of the query stack

17eb8d8

run full query stack print just when RUST_BACKTRACE is set

20ea929

fix invalid-punct-ident-1 test

7ccca35

add filter regexes to load-panic-backtraces test

d6d4388

fix show we're just showing... message instead of the end of query st…

d60b7e2

…ack message when RUST_BACKTRACE=0

fix clippy custom_ice_message test

6e7e4ac

add new line

15663a4

rebase with master

2124e9b

ICEs should print the top of the query stack

2b91b7f

run full query stack print just when RUST_BACKTRACE is set

01f838a

change approach and run ui tests

2bfdd64

show a message when we are showing limited slice of query stack

b6e9f08

fix invalid-punct-ident-1 test

3c56ba5

add filter regexes to load-panic-backtraces test

d1e3059

hosseind75 and others added 5 commits October 9, 2020 20:57

fix show we're just showing... message instead of the end of query st…

6c0f06a

…ack message when RUST_BACKTRACE=0

remove new line

c61d95b

revert deleted new line

998186e

delete const-pat-ice test stderr

42ebae3

change condition for end of query stack message

73d8f00

fix stderr file of clippy/custom_ice_message test

46cc889

hosseind88 force-pushed the ICEs_should_always_print_the_top_of_the_query_stack branch from 668aaeb to 46cc889 Compare October 14, 2020 14:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2020

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 15, 2020

Rollup merge of rust-lang#77493 - hosseind88:ICEs_should_always_print…

122f5c1

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

JohnTitor mentioned this pull request Oct 15, 2020

Rollup of 12 pull requests #77999

Closed

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Oct 15, 2020

Rollup merge of rust-lang#77493 - hosseind88:ICEs_should_always_print…

e16dee1

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

This was referenced Oct 15, 2020

Rollup of 13 pull requests #78000

Closed

Rollup of 14 pull requests #78001

Merged

bors merged commit 0e4d196 into rust-lang:master Oct 16, 2020

rustbot added this to the 1.49.0 milestone Oct 16, 2020

bors pushed a commit to rust-lang-ci/rust that referenced this pull request Oct 24, 2020

Rollup merge of rust-lang#77493 - hosseind88:ICEs_should_always_print…

d2feccc

…_the_top_of_the_query_stack, r=oli-obk ICEs should always print the top of the query stack see rust-lang#76920

GroteGnoom mentioned this pull request Jan 7, 2021

ICEs should always print the top of the query stack. #70953

Closed

camelid mentioned this pull request Jan 29, 2021

Move treat err as bug tests to ui #71531

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ICEs should always print the top of the query stack #77493

ICEs should always print the top of the query stack #77493

hosseind88 commented Oct 3, 2020 •

edited

Loading

rust-highfive commented Oct 3, 2020

hosseind88 commented Oct 3, 2020 •

edited

Loading

bjorn3 Oct 3, 2020

hosseind88 Oct 3, 2020

oli-obk commented Oct 5, 2020

hosseind88 commented Oct 6, 2020

oli-obk Oct 7, 2020

oli-obk commented Oct 7, 2020

ThibsG commented Oct 8, 2020

oli-obk Oct 9, 2020

hosseind88 commented Oct 12, 2020

oli-obk commented Oct 12, 2020

hosseind88 commented Oct 14, 2020

oli-obk commented Oct 15, 2020

bors commented Oct 15, 2020

ICEs should always print the top of the query stack #77493

ICEs should always print the top of the query stack #77493

Conversation

hosseind88 commented Oct 3, 2020 • edited Loading

rust-highfive commented Oct 3, 2020

hosseind88 commented Oct 3, 2020 • edited Loading

bjorn3 Oct 3, 2020

Choose a reason for hiding this comment

hosseind88 Oct 3, 2020

Choose a reason for hiding this comment

oli-obk commented Oct 5, 2020

hosseind88 commented Oct 6, 2020

oli-obk Oct 7, 2020

Choose a reason for hiding this comment

oli-obk commented Oct 7, 2020

ThibsG commented Oct 8, 2020

oli-obk Oct 9, 2020

Choose a reason for hiding this comment

hosseind88 commented Oct 12, 2020

oli-obk commented Oct 12, 2020

hosseind88 commented Oct 14, 2020

oli-obk commented Oct 15, 2020

bors commented Oct 15, 2020

hosseind88 commented Oct 3, 2020 •

edited

Loading

hosseind88 commented Oct 3, 2020 •

edited

Loading