Support vectors with fewer than 8 elements for simd_select_bitmask #77504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -793,14 +793,16 @@ fn generic_simd_intrinsic( | |||
| require_simd!(arg_tys[1], "argument"); | |||
| let v_len = arg_tys[1].simd_size(tcx); | |||
| require!( | |||
| m_len == v_len, | |||
| m_len == v_len || (m_len == 8 && v_len < 8), | |||
There was a problem hiding this comment.
Can you add a comment above the require that explains this? I found the juxtaposition between this and the error message below a bit confusing.
|
r=me with CI passing and some kind of comment. |
Amanieu
force-pushed
the
select_simd_bitmask
branch
from
e7e6c43 to
e41a144
Compare
|
@bors r=ecstatic-morse |
|
📌 Commit e41a144 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2020
…as-schievink Rollup of 8 pull requests Successful merges: - rust-lang#77072 (Minor `hash_map` doc adjustments + item attribute orderings) - rust-lang#77368 (Backport LLVM apfloat commit to rustc_apfloat) - rust-lang#77445 (BTreeMap: complete the compile-time test_variance test case) - rust-lang#77504 (Support vectors with fewer than 8 elements for simd_select_bitmask) - rust-lang#77513 (Change DocFragments from enum variant fields to structs with a nested enum) - rust-lang#77518 (Only use Fira Sans for the first `td` in item lists) - rust-lang#77521 (Move target feature whitelist from cg_llvm to cg_ssa) - rust-lang#77525 (Enable RenameReturnPlace MIR optimization on mir-opt-level >= 2) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the issue raised here: rust-lang/stdarch#310 (comment)