Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Abort terminators in all const-contexts #77512

Merged
merged 6 commits into from
Oct 5, 2020
Merged

Allow Abort terminators in all const-contexts #77512

merged 6 commits into from
Oct 5, 2020

Commits on Oct 3, 2020

  1. Allow Abort terminators in a const-context 

    These appear along the cleanup path inside functions with
`#[unwind(aborts)]`. We don't const-check the cleanup path anyways,
since const-eval already has "abort-on-panic" semantics and there's
often drops that would otherwise be forbidden, so the check wasn't
really preventing anything anyways.
    @ecstatic-morse
    ecstatic-morse committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    98a2292 View commit details
    Browse the repository at this point in the history

  2. Add check-pass test for #[unwind(aborts)] on a const fn

    @ecstatic-morse
    ecstatic-morse committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    a5f0831 View commit details
    Browse the repository at this point in the history

  3. Ensure that the const-eval engine handles #[unwind(aborts)]

    @ecstatic-morse
    ecstatic-morse committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    14c3705 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2020

  1. Discuss cleanup blocks and span_bug on Abort

    @ecstatic-morse
    ecstatic-morse committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    25fdbaf View commit details
    Browse the repository at this point in the history

  2. Add comment to Abort match arm 

    Co-authored-by: Ralf Jung <post@ralfj.de>
    @ecstatic-morse @RalfJung
    ecstatic-morse and RalfJung authored Oct 4, 2020
    Configuration menu
    Copy the full SHA
    fe97990 View commit details
    Browse the repository at this point in the history

  3. But whatever

    @ecstatic-morse
    ecstatic-morse authored Oct 4, 2020
    Configuration menu
    Copy the full SHA
    6ae1da3 View commit details
    Browse the repository at this point in the history