Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow overriding forbid in same scope #77534

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Disallow overriding forbid in same scope #77534

merged 2 commits into from
Oct 6, 2020

Commits on Oct 4, 2020

  1. rewrite old test so that its attributes are consistent with what we w… 

    …ant in the language.

(Note that the fact this test existed is a slight sign that we may need a crater
run on this bugfix...)
    @pnkfelix @Mark-Simulacrum
    pnkfelix authored and Mark-Simulacrum committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    b4e77d2 View commit details
    Browse the repository at this point in the history

  2. Prevent forbid from being ignored if overriden at the same level. 

    That is, this changes `#[forbid(foo)] #[allow(foo)]` from allowing foo to
forbidding foo.
    @pnkfelix @Mark-Simulacrum
    pnkfelix authored and Mark-Simulacrum committed Oct 4, 2020
    Configuration menu
    Copy the full SHA
    afa2a67 View commit details
    Browse the repository at this point in the history