-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use RTLD_DEEPBIND
for loading dylibs/proc-macros
#77545
Use RTLD_DEEPBIND
for loading dylibs/proc-macros
#77545
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
It would be good to make sure DEEPBIND is supported on other platforms as well (e.g., macOS/Windows). Is there a chance we could engineer a test that intentionally clashes symbols with rustc? (I am fine with adding a "well known" export to rustc that we could clash with fwiw). |
I believe |
@bors try |
⌛ Trying commit 03b326d with merge 6fa7016b655ed9c063536a8c01874ecdc82b345d... |
☀️ Try build successful - checks-actions, checks-azure |
I don't have any domain-specific knowledge here. |
Local testing seems to indicate this doesn't fix the bug. |
Yeah, I was using local system LLVM, which masked the bug |
This should fix #76980, by loading symbols from proc macro dylibs from the dylib itself, before falling back to symbols provided by the compiler or its dependencies.