liballoc: VecDeque: Add binary search functions #77751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @dtolnay (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
vojtechkral
force-pushed
the
vecdeque-binary-search
branch
from
d2bb567 to
a4b160e
Compare
vojtechkral
force-pushed
the
vecdeque-binary-search
branch
from
a4b160e to
36d9b72
Compare
dtolnay
approved these changes
Oct 15, 2020
scottmcm
reviewed
Oct 15, 2020
5 tasks
vojtechkral
force-pushed
the
vecdeque-binary-search
branch
from
8659a11 to
c7a787a
Compare
|
Added a tracking issue, simplified implementation as suggested by @scottmcm ... |
|
Stability attributes and code updates look good to me; thanks! @bors r=scottmcm,dtolnay (Feel free to |
|
📌 Commit c7a787a has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Oct 17, 2020
… r=scottmcm,dtolnay liballoc: VecDeque: Add binary search functions I am submitting rust-lang/rfcs#2997 as a PR as suggested by @scottmcm I haven't yet created a tracking issue - if there's a favorable feedback I'll create one and update the issue links in the unstable attribs.
This was referenced Oct 17, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 17, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#76199 (Permit uninhabited enums to cast into ints) - rust-lang#77751 (liballoc: VecDeque: Add binary search functions) - rust-lang#77785 (Remove compiler-synthesized reexports when documenting) - rust-lang#77932 (BTreeMap: improve gdb introspection of BTreeMap with ZST keys or values) - rust-lang#77961 (Set .llvmbc and .llvmcmd sections as allocatable) - rust-lang#77985 (llvm: backport SystemZ fix for AGR clobbers) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am submitting rust-lang/rfcs#2997 as a PR as suggested by @scottmcm
I haven't yet created a tracking issue - if there's a favorable feedback I'll create one and update the issue links in the unstable attribs.Tracking issue: #78021