Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreachable propagation: preserve information about unreachable values #77800

Closed
wants to merge 4 commits into from
Closed

Unreachable propagation: preserve information about unreachable values #77800

wants to merge 4 commits into from

Commits on Oct 10, 2020

  1. Turn on UnreachablePropagation by default

    @jonas-schievink @tmiasko
    jonas-schievink authored and tmiasko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    4893c11 View commit details
    Browse the repository at this point in the history

  2. Bless mir-opt tests

    @jonas-schievink @tmiasko
    jonas-schievink authored and tmiasko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    2b641de View commit details
    Browse the repository at this point in the history

  3. Unreachable propagation: preserve information about unreachable values 

    Unreachable propagation pass removes all unreachable terminators.
As a consequence, for switch int terminators, where two or more targets
remain after the optimization, where otherwise branch is reachable,
switching on unreachable values will use otherwise branch after the
optimization. Consequently, the information about unreachable values is
irrevocably lost.

To preserve the information about unreachable values, keep the existing
terminator if otherwise branch is reachable. Additionally, since now
unreachable blocks might remain in use, remove their statements.
    @tmiasko
    tmiasko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    134f3da View commit details
    Browse the repository at this point in the history

  4. Use meaningful predicate name

    @tmiasko
    tmiasko committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    1ad305e View commit details
    Browse the repository at this point in the history