Stabilize clamp

[Xaeroxe]

Tracking issue: #44095

Clamp has been merged and unstable for about a year and a half now. How do we feel about stabilizing this?

[rust-highfive]

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

[KodrAus]

This seems reasonable to me!

This stabilizes the following methods on Ord, as well as f32 and f64:

pub trait Ord {
    fn clamp(self, min: Self, max: Self) -> Self { .. }
}

impl f32 {
    pub fn clamp(self, min: f32, max: f32) -> f32;
}

impl f64 {
    pub fn clamp(self, min: f64, max: f64) -> f64;
}

We need to provide inherent methods on f32 and f64 because they don't implement the Ord trait. I don't think we have any plans to implement Ord for floating points directly, but do have some total ordering methods that showed up recently.

The methods were originally RFC'd here.

There was also an FCP open here previously that went stale some time ago. It was suggested we just kick off a new one since the shape of Libs has changed a fair bit in the intervening years.

@rfcbot fcp merge

[rfcbot]

Team member @KodrAus has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @KodrAus
• @dtolnay
• @sfackler
• @withoutboats

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[scottmcm]

We need to provide inherent methods on f32 and f64 because they don't implement the Ord trait. I don't think we have any plans to implement Ord for floating points directly, but do have some total ordering methods that showed up recently.

There's Ord::min and f32::min already, so I don't think having Ord::clamp and f32::clamp adds any new hazards here.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

[scottmcm]

The code changes look good to me, so with the FCP completed without controversy,
r? @scottmcm
@bors r+ rollup

[bors]

📌 Commit fb6ceac has been approved by scottmcm

[bors]

⌛ Testing commit fb6ceac with merge c9e97885881f2547625bc416e550499ed4f243ae...

[bors]

💔 Test failed - checks-actions

[scottmcm]

fatal: unable to access 'https://github.com/BurntSushi/ripgrep/': Could not resolve host: github.com
thread 'main' panicked at 'assertion failed: status.success()', src\tools\cargotest\main.rs:96:13

@bors retry

[bors]

⌛ Testing commit fb6ceac with merge 5d5ff84...

[bors]

☀️ Test successful - checks-actions
Approved by: scottmcm
Pushing 5d5ff84 to master...