-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #77904
Closed
Closed
Rollup of 10 pull requests #77904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also allows 'rustdoc' as a string for the compiler profile.
Co-authored-by: varkor <github@varkor.com>
Co-authored-by: varkor <github@varkor.com>
Co-authored-by: varkor <github@varkor.com>
Fixes rust-lang#55890 It's useful to have `llc` and `opt` available when debugging an LLVM miscompilation,.
Modern compilers allow reaching external crates like std or core via relative paths in modules outside of lib.rs and main.rs.
…oalbini Enable building Cargo for aarch64-apple-darwin r? @ghost
…ulacrum BTreeMap: type-specific variants of node_as_mut and cast_unchecked Improves debug checking and shortens some expressions. Extracted from rust-lang#77408
…mutex-attr-cleanup, r=Mark-Simulacrum Remove unnecessary rustc_const_stable attributes. These attributes were added in rust-lang#74033 (comment) because of [std::io::lazy::Lazy::new](https://github.com/rust-lang/rust/blob/0c03aee8b81185d65b5821518661c30ecdb42de5/src/libstd/io/lazy.rs#L21-L23). But [std::io::lazy::Lazy is gone now](rust-lang#77154), so this can be cleaned up. @rustbot modify labels: +T-libs +C-cleanup
Give an error when running `x.py test --stage 0 src/test/ui` The error can be overridden with `COMPILETEST_FORCE_STAGE0=1`. In practice I don't know why anyone would do this. r? @Mark-Simulacrum Closes rust-lang#77711
Mention rustdoc in `x.py setup` This lets new contributors know which option they should pick; previously it wasn't clear 'compiler' also included rustdoc. Unresolved questions: should this say 'compiler and tools' instead? I don't know of any tools that are modified in-tree other than rustdoc, though. r? @Mark-Simulacrum
…stic, r=lcnr `min_const_generics` diagnostics improvements As disscussed in [zulip/project-const-generics/non-trivial anonymous constant](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/non-trivial.20anonymous.20constants). This is my first PR on the compiler. @lcnr is mentoring me on this PR. Related to rust-lang#60551.
…k-Simulacrum Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component Fixes rust-lang#55890 It's useful to have `llc` and `opt` available when debugging an LLVM miscompilation,.
Use Option::unwrap_or instead of open-coding it
…hs, r=lcnr Replace absolute paths with relative ones Modern compilers allow reaching external crates like std or core via relative paths in modules outside of lib.rs and main.rs.
…roalbini Include aarch64-apple-darwin in the dist manifests r? @ehuss /cc @pietroalbini @Mark-Simulacrum
📌 Commit 7664cbf has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Oct 13, 2020
⌛ Testing commit 7664cbf with merge 8828cdacaf53fad994336697e784f008fb5f23fa... |
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 13, 2020
Might be related to a current outage |
@bors treeclosed=100 |
Ohh, it's just now resolved :) |
Anyways I'd let #75213 go and re-create another rollup, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rollup
A PR which is a rollup
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
x.py test --stage 0 src/test/ui
#77776 ( Give an error when runningx.py test --stage 0 src/test/ui
)x.py setup
#77786 (Mention rustdoc inx.py setup
)min_const_generics
diagnostics improvements #77825 (min_const_generics
diagnostics improvements)llvm-dis
,llc
andopt
inllvm-tools-preview
component #77868 (Includellvm-dis
,llc
andopt
inllvm-tools-preview
component)Failed merges:
r? @ghost