Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

f64: Refactor collapsible_if #77921

Merged
merged 1 commit into from
Oct 30, 2020
Merged

f64: Refactor collapsible_if #77921

merged 1 commit into from
Oct 30, 2020

Conversation

wcampbell0x2a
Copy link
Contributor

No description provided.

@wcampbell0x2a
Refactor collapsible_if
096722f 
Signed-off-by: wcampbell <wcampbell1995@gmail.com>
@rust-highfive
Copy link
Collaborator

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2020
@shepmaster
Copy link
Member

Can you explain why this refactoring is beneficial?

@wcampbell0x2a
Copy link
Contributor Author

wcampbell0x2a commented Oct 13, 2020 •
edited
Loading

Can you explain why this refactoring is beneficial?

This creates a more apparent pattern in that the other else if clauses are also part of the alternative part of the first conditional if !cfg!(any(target_os = "solaris", target_os = "illumos")) { instead of being part of another nested if.

@jyn514 jyn514 added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 30, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 30, 2020

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 30, 2020

📌 Commit 096722f has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2020
@JohnTitor JohnTitor mentioned this pull request Oct 30, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2020
@bors
Auto merge of rust-lang#78562 - JohnTitor:rollup-otg906u, r=JohnTitor
388ef34 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#77334 (Reorder benches const variable)
 - rust-lang#77888 (Simplify a nested bool match)
 - rust-lang#77921 (f64: Refactor collapsible_if)
 - rust-lang#78523 (Revert invalid `fn` return type parsing change)
 - rust-lang#78524 (Avoid BorrowMutError with RUSTC_LOG=debug)
 - rust-lang#78545 (Make anonymous binders start at 0)
 - rust-lang#78554 (Improve wording of `core::ptr::drop_in_place` docs)
 - rust-lang#78556 (Link to pass docs from NRVO module docs)

Failed merges:

 - rust-lang#78424 (Fix some more clippy warnings)

r? `@ghost`
@bors bors merged commit 02a4b58 into rust-lang:master Oct 30, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 30, 2020
@camelid camelid added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

@jyn514 jyn514 jyn514 left review comments

Assignees

@shepmaster shepmaster

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
7 participants
@wcampbell0x2a @rust-highfive @shepmaster @jyn514 @bors @camelid @rustbot