Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 3 pull requests #77981

Merged
merged 6 commits into from
Oct 15, 2020
Merged

Rollup of 3 pull requests #77981

merged 6 commits into from
Oct 15, 2020

Conversation

GuillaumeGomez
Copy link
Member

Successful merges:

Failed merges:

r? @ghost

kraai and others added 6 commits October 15, 2020 00:57
@kraai
Fix link to foreign calling conventions
f2a237a
@strct
Fix typo in documentation
8d8554d
@GuillaumeGomez
Hide help button on mobile devices
fce04fe
@GuillaumeGomez
Rollup merge of rust-lang#77963 - kraai:fix-foreign-calling-conventio…
e117c06 
…ns-link, r=jonas-schievink

Fix link to foreign calling conventions
@GuillaumeGomez
Rollup merge of rust-lang#77978 - strct:patch-2, r=jonas-schievink
313de68 
Fix typo in documentation
@GuillaumeGomez
Rollup merge of rust-lang#77979 - GuillaumeGomez:hide-help-button, r=…
16b1a6f 
…jyn514

Hide help button on mobile

Addresses rust-lang#77899.

This PR is just a quick fix for now: we're still debating about whether or not we want to display this help popup and if so, how. I'll open an issue once this PR is merged to discuss about it.

Before:

![Screenshot from 2020-10-15 17-56-39](https://user-images.githubusercontent.com/3050060/96155127-df499680-0f0f-11eb-8a13-77c537141f21.png)

After:

![Screenshot from 2020-10-15 17-55-06](https://user-images.githubusercontent.com/3050060/96154957-ac070780-0f0f-11eb-9d90-7d8f79a6bf37.png)

r? @jyn514
@GuillaumeGomez
Copy link
Member Author

@bors: r+ p=3

@bors
Copy link
Contributor

bors commented Oct 15, 2020

📌 Commit 16b1a6f has been approved by GuillaumeGomez

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 15, 2020
@bors
Copy link
Contributor

bors commented Oct 15, 2020

⌛ Testing commit 16b1a6f with merge dd7fc54...

@JohnTitor JohnTitor added the rollup A PR which is a rollup label Oct 15, 2020
@bors
Copy link
Contributor

bors commented Oct 15, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: GuillaumeGomez
Pushing dd7fc54 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 15, 2020
@bors bors merged commit dd7fc54 into rust-lang:master Oct 15, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 15, 2020
@bors bors mentioned this pull request Oct 15, 2020
Closed
@TimDiekmann TimDiekmann mentioned this pull request Oct 16, 2020
Closed
@GuillaumeGomez GuillaumeGomez deleted the rollup-64ydc5g branch October 16, 2020 08:03
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 18, 2024
Open
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @bors @JohnTitor @rustbot @kraai @strct